-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpk: improved err msg in rpk tune --output-script #13473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user used a directory it would fail without giving any meaningful error.
0x5d
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM logic-wise. I'll defer the review of message wording.
twmb
approved these changes
Sep 16, 2023
gene-redpanda
approved these changes
Sep 18, 2023
/backport v23.2.x |
/backport v23.1.x |
/backport v22.3.x |
Failed to create a backport PR to v22.3.x branch. I tried:
|
Failed to create a backport PR to v23.1.x branch. I tried:
|
This was referenced Sep 19, 2023
r-vasquez
added a commit
to r-vasquez/redpanda
that referenced
this pull request
Sep 19, 2023
If the user used a directory it would fail without giving any meaningful error. Manual Backport of PR redpanda-data#13473
This was referenced Sep 19, 2023
r-vasquez
added a commit
to r-vasquez/redpanda
that referenced
this pull request
Sep 19, 2023
If the user used a directory it would fail without giving any meaningful error. Manual Backport of PR redpanda-data#13473
gousteris
added a commit
to gousteris/redpanda
that referenced
this pull request
Sep 28, 2023
ref fix of redpanda-data#13548 re-backport of redpanda-data#13473 fixes redpadnda-data/devprod#856
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user used a directory it would fail and panic without giving any meaningful error.
Backports Required
Release Notes
Bug Fixes
rpk redpanda tune --output-script