Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk: improved err msg in rpk tune --output-script #13473

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

r-vasquez
Copy link
Contributor

If the user used a directory it would fail and panic without giving any meaningful error.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.2.x
  • v23.1.x
  • v22.3.x

Release Notes

Bug Fixes

  • rpk: prevent panic when using a directory instead of a filename in rpk redpanda tune --output-script

If the user used a directory it would fail without
giving any meaningful error.
Copy link
Contributor

@0x5d 0x5d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM logic-wise. I'll defer the review of message wording.

@twmb twmb merged commit ea167b6 into redpanda-data:dev Sep 19, 2023
10 checks passed
@twmb twmb deleted the check-for-dir-tune branch September 19, 2023 11:16
@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.1.x

@vbotbuildovich
Copy link
Collaborator

/backport v22.3.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v22.3.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-13473-v22.3.x-898 remotes/upstream/v22.3.x
git cherry-pick -x 35e6b394bd53141e3257ee06535e1605a8a65b45

Workflow run logs.

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.1.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-13473-v23.1.x-858 remotes/upstream/v23.1.x
git cherry-pick -x 35e6b394bd53141e3257ee06535e1605a8a65b45

Workflow run logs.

r-vasquez added a commit to r-vasquez/redpanda that referenced this pull request Sep 19, 2023
If the user used a directory it would fail without
giving any meaningful error.

Manual Backport of PR redpanda-data#13473
r-vasquez added a commit to r-vasquez/redpanda that referenced this pull request Sep 19, 2023
If the user used a directory it would fail without
giving any meaningful error.

Manual Backport of PR redpanda-data#13473
gousteris added a commit to gousteris/redpanda that referenced this pull request Sep 28, 2023
ref
fix of redpanda-data#13548
re-backport of redpanda-data#13473

fixes redpadnda-data/devprod#856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants