Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v22.3.x] rpk: improved err msg in rpk tune --output-script #13548

Merged

Conversation

r-vasquez
Copy link
Contributor

If the user used a directory it would fail without giving any meaningful error.

Manual Backport of PR #13473

Fixes #13540

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.2.x
  • v23.1.x
  • v22.3.x

Release Notes

Bug Fixes

  • rpk: prevent panic when using a directory instead of a filename in rpk redpanda tune --output-script

If the user used a directory it would fail without
giving any meaningful error.

Manual Backport of PR redpanda-data#13473
@r-vasquez
Copy link
Contributor Author

@r-vasquez r-vasquez merged commit 62ffb60 into redpanda-data:v22.3.x Sep 19, 2023
8 checks passed
gousteris added a commit to gousteris/redpanda that referenced this pull request Sep 28, 2023
ref
fix of redpanda-data#13548
re-backport of redpanda-data#13473

fixes redpadnda-data/devprod#856
@BenPope BenPope added the kind/backport PRs targeting a stable branch label Oct 10, 2023
@BenPope BenPope added this to the v22.3.24 milestone Oct 10, 2023
@r-vasquez r-vasquez deleted the manual-backport-13473-v22.3.x branch December 6, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rpk kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants