Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.2.x] rpk: improved err msg in rpk tune --output-script #13539

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[v23.2.x] rpk: improved err msg in rpk tune --output-script #13539

merged 1 commit into from
Sep 19, 2023

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #13473

@r-vasquez @vbotbuildovich
rpk: improved err msg in rpk tune --output-script
893e32e 
If the user used a directory it would fail without
giving any meaningful error.

(cherry picked from commit 35e6b39)
@vbotbuildovich vbotbuildovich added this to the v23.2.x-next milestone Sep 19, 2023
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Sep 19, 2023
@r-vasquez r-vasquez marked this pull request as ready for review September 19, 2023 13:09
@r-vasquez
Copy link
Contributor

r-vasquez commented Sep 19, 2023 •
edited
Loading

Unrelated Failure:

The fix was not backported, and it's in dev: #11268

@twmb twmb merged commit 9963ffc into redpanda-data:v23.2.x Sep 19, 2023
10 checks passed
@piyushredpanda piyushredpanda modified the milestones: v23.2.x-next, v23.2.10 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gene-redpanda gene-redpanda gene-redpanda approved these changes

@r-vasquez r-vasquez r-vasquez approved these changes

@twmb twmb Awaiting requested review from twmb twmb is a code owner

Assignees
No one assigned
Labels
area/rpk kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.2.10
Development

Successfully merging this pull request may close these issues.
5 participants
@vbotbuildovich @r-vasquez @gene-redpanda @twmb @piyushredpanda