-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retest: Implement VPC peering for Cloud Cluster with private network #12918
Conversation
In order not to have long list of arguments in each internal functions, use self.current as a data store. Each of the _*_payload functions and _get_* will use it as a source of data to create proper body for REST request
BYOC cloud is created in Operator's provider account. Due to this, CloudV2 API can't be used for Peering creation. I.e. we will not be able to put routes and acccess data. So, BYOC required separate workflow. Functions broken down to steps and each workflow uses common set of routines as well as own specific ones.
checkpoint: all PR checks for a037609 are green i'll kick off a simple |
/cdt |
/cdt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i encountered an error when running this with a given clusterId
bash$ ducktape --debug --globals=/home/ubuntu/redpanda/tests/globals.json --cluster=ducktape.cluster.json.JsonCluster --cluster-file=/home/ubuntu/redpanda/tests/cluster.json tests/rptest/tests/services_self_test.py::OpenBenchmarkSelfTest
...
[WARNING - 2023-08-22 22:11:02,514 - redpanda_cloud - create - lineno:426]: will not create cluster; already have cluster_id ci0motok30vsi89l501g
[INFO - 2023-08-22 22:11:04,559 - runner_client - log - lineno:278]: RunnerClient: rptest.tests.services_self_test.OpenBenchmarkSelfTest.test_default_omb_configuration.driver=SIMPLE_DRIVER.workload=SIMPLE_WORKLOAD: FAIL: KeyError('productId')
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/ducktape/tests/runner_client.py", line 133, in run
self.setup_test()
File "/usr/local/lib/python3.10/dist-packages/ducktape/tests/runner_client.py", line 218, in setup_test
self.test.setup()
File "/usr/local/lib/python3.10/dist-packages/ducktape/tests/test.py", line 91, in setup
self.setUp()
File "/home/ubuntu/redpanda/tests/rptest/tests/redpanda_test.py", line 110, in setUp
self.redpanda.start()
File "/home/ubuntu/redpanda/tests/rptest/services/redpanda.py", line 1490, in start
cluster_id = self._cloud_cluster.create(superuser=superuser)
File "/home/ubuntu/redpanda/tests/rptest/services/redpanda_cloud.py", line 429, in create
self._update_live_cluster_info()
File "/home/ubuntu/redpanda/tests/rptest/services/redpanda_cloud.py", line 403, in _update_live_cluster_info
self.current.product_id = _c['productId']
KeyError: 'productId'
checkpoint: a037609 also passed the cdt check: https://buildkite.com/redpanda/redpanda/builds/35448 |
Includes fixes for findings when running against GCP provider
a037609
to
4ab3b17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
i verified by running same test on my dev env and stuff works
/backport v23.2.x |
Failed to run cherry-pick command. I executed the commands below:
|
Create VPC peering for deployed cloud with private network
Steps:
BYOC VPC Peering.
FMC VPC Peering
Prior to implementing, in order not to have long list of arguments in each internal functions, use self.current as a data store. Each of the __payload functions and get will use it as a source of data to create proper body for REST request
Backports Required
Release Notes