Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rptest: handle errors from cloudv2 and rethrow proper error messages #12915

Merged
merged 1 commit into from
Aug 23, 2023
Merged

rptest: handle errors from cloudv2 and rethrow proper error messages #12915

merged 1 commit into from
Aug 23, 2023

Conversation

savex
Copy link
Contributor

@savex savex commented Aug 21, 2023 •
edited by ivotron
Loading

When CloudV2 returns error, save it in addition to logging to be able to re-throw them later

ref: https://github.com/redpanda-data/cloudv2/issues/7904

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.2.x
  • v23.1.x
  • v22.3.x

Release Notes

  • none

@savex savex requested a review from andrewhsu August 21, 2023 19:36
@savex savex self-assigned this Aug 22, 2023
@savex savex added the team/devprod display on zenhub workspace for devprod team label Aug 22, 2023
@andrewhsu
Copy link
Member

ci error looks known:

andrewhsu
andrewhsu approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@savex
Copy link
Contributor Author

savex commented Aug 23, 2023

Was tested manually along with #12918

@savex savex merged commit c297f10 into dev Aug 23, 2023
50 checks passed
@savex savex deleted the cdt-handle-cloudv2-errors branch August 23, 2023 15:52
@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

@vbotbuildovich vbotbuildovich mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewhsu andrewhsu andrewhsu approved these changes

Assignees

@savex savex

Labels
team/devprod display on zenhub workspace for devprod team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@savex @andrewhsu @vbotbuildovich