Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

com.redhat.devtools.intellij.common.utils.function.TriConsumer is causing incompatibility to IC-2022.3 - IC-2024.1 #222

Closed
adietish opened this issue Apr 16, 2024 · 0 comments · Fixed by #223
Closed

com.redhat.devtools.intellij.common.utils.function.TriConsumer is causing incompatibility to IC-2022.3 - IC-2024.1 #222

adietish opened this issue Apr 16, 2024 · 0 comments · Fixed by #223
Assignees
@adietish
Labels
IC-2022.3 IC-2024.1 severity/major
Milestone
1.9.5

Comments

@adietish
Copy link
Contributor

adietish commented Apr 16, 2024 •
edited
Loading

related to #224
image

com.redhat.devtools.intellij.common.utils.function.TriConsumer is only used by intellij-tekton. Tekton cannot use latest intellij-common 1.9.4 because it cannot bump to the same kubernetes-client 6.12.0 (see redhat-developer/intellij-tekton#668 (comment))
We can therefore remove com.redhat.devtools.intellij.common.utils.function.TriConsumer. In Jetbrains platform there's a class com.intellij.util.TriConsumer which is missing the method andThen though:

default TriConsumer<A, B, C> andThen(TriConsumer<? super A, ? super B, ? super C> after) {
    Objects.requireNonNull(after);
    return (A a, B b, C c) -> {
        accept(a, b, c);
        after.accept(a, b, c);
    };
}
@adietish adietish self-assigned this Apr 16, 2024
@adietish adietish mentioned this issue Apr 16, 2024
Closed
adietish added a commit to adietish/intellij-common that referenced this issue Apr 17, 2024
@adietish
removed custom TriConsumer (redhat-developer#222)
ab88400 
TriConsumer triggers incompatibility warnings in jetbrains marketplace.
intellij-tekton is using it but it cannot bump to latest common version
bcs of the outdated kubernetes-client that it needs to use
(see redhat-developer/intellij-tekton#668).

Signed-off-by: Andre Dietisheim <[email protected]>
@adietish adietish mentioned this issue Apr 17, 2024
Merged
adietish added a commit that referenced this issue Apr 17, 2024
@adietish
removed custom TriConsumer (#222)
e924cdf 
TriConsumer triggers incompatibility warnings in jetbrains marketplace.
intellij-tekton is using it but it cannot bump to latest common version
bcs of the outdated kubernetes-client that it needs to use
(see redhat-developer/intellij-tekton#668).

Signed-off-by: Andre Dietisheim <[email protected]>
@adietish adietish moved this to ✅ Done in IDE Cloudaptors Apr 17, 2024
@adietish adietish added this to the 1.9.5 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adietish adietish

Labels
IC-2022.3 IC-2024.1 severity/major
Projects
IDE Cloudaptors
Status: ✅ Done
Milestone
1.9.5
Development

Successfully merging a pull request may close this issue.

fix: removed custom TriConsumer (#222) adietish/intellij-common
1 participant
@adietish