Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.3.0 is incompatible to all IC starting with IC-2022.3 up to IC-2024.1 #749

Closed
adietish opened this issue Apr 16, 2024 · 0 comments · Fixed by #750
Closed

1.3.0 is incompatible to all IC starting with IC-2022.3 up to IC-2024.1 #749

adietish opened this issue Apr 16, 2024 · 0 comments · Fixed by #750
Assignees
@adietish
Labels
IC-2022.3 IC-2024.1 kind/bug Something isn't working
Milestone
1.3.0

Comments

@adietish
Copy link
Collaborator

adietish commented Apr 16, 2024 •
edited
Loading

related to #738
related to redhat-developer/intellij-common#222

image

The problem here is com.redhat.devtools.intellij.common.utils.function.TriConsumer which lives in intellij-common 1.9.4. Without it, there's only an incompatiblity to IC-2022.3 left:

image
@adietish adietish added this to the 1.3.0 milestone Apr 16, 2024
@adietish adietish self-assigned this Apr 16, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Apr 17, 2024
@adietish
removed call to ExtensionPointName.create (redhat-developer#749)
7cc5cf2 
Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Apr 17, 2024
@adietish
made instantiation of PresentationFactory compatible (redhat-develope…
1015669 
…r#749)

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Apr 17, 2024
@adietish
removed TriConsumer from commons to make build compatible (redhat-dev…
f14b3b2 
…eloper#749)

Signed-off-by: Andre Dietisheim <[email protected]>
@adietish adietish mentioned this issue Apr 17, 2024
Merged
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Apr 17, 2024
@adietish
made instantiation of PresentationFactory compatible (redhat-develope…
8193745 
…r#749)

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Apr 17, 2024
@adietish
removed TriConsumer from commons to make build compatible (redhat-dev…
6f6ce1c 
…eloper#749)

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Apr 17, 2024
@adietish
fix: corrected incompatibilities (redhat-developer#749)
bd7ea0f 
* removed call to ExtensionPointName.create (redhat-developer#749)
* made instantiation of PresentationFactory compatible (redhat-developer#749)
* removed TriConsumer from commons to make build compatible (redhat-developer#749)
* removed deprecated UtilKt.isNull0rEmpty(Collection)(redhat-developer#749)
* removed deprecated EdtInvocationManager.isEventDispatchThread(redhat-developer#749)
* replaced deprecated StructureTreeModel.invalidate()(redhat-developer#749)

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Apr 17, 2024
@adietish
fix: corrected incompatibilities (redhat-developer#749)
98a89ca 
* removed call to ExtensionPointName.create (redhat-developer#749)
* made instantiation of PresentationFactory compatible (redhat-developer#749)
* removed TriConsumer from commons to make build compatible (redhat-developer#749)
* removed deprecated UtilKt.isNull0rEmpty(Collection)(redhat-developer#749)
* removed deprecated EdtInvocationManager.isEventDispatchThread(redhat-developer#749)
* replaced deprecated StructureTreeModel.invalidate()(redhat-developer#749)

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Apr 17, 2024
@adietish
fix: corrected incompatibilities (redhat-developer#749)
2671e07 
* removed call to ExtensionPointName.create (redhat-developer#749)
* made instantiation of PresentationFactory compatible (redhat-developer#749)
* removed TriConsumer from commons to make build compatible (redhat-developer#749)
* removed deprecated UtilKt.isNull0rEmpty(Collection)(redhat-developer#749)
* removed deprecated EdtInvocationManager.isEventDispatchThread(redhat-developer#749)
* replaced deprecated StructureTreeModel.invalidate()(redhat-developer#749)

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Apr 17, 2024
@adietish
fix: corrected incompatibilities (redhat-developer#749)
118f625 
* removed call to ExtensionPointName.create (redhat-developer#749)
* made instantiation of PresentationFactory compatible (redhat-developer#749)
* removed TriConsumer from commons to make build compatible (redhat-developer#749)
* removed deprecated UtilKt.isNull0rEmpty(Collection)(redhat-developer#749)
* removed deprecated EdtInvocationManager.isEventDispatchThread(redhat-developer#749)
* replaced deprecated StructureTreeModel.invalidate()(redhat-developer#749)

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit that referenced this issue Apr 17, 2024
@adietish
fix: corrected incompatibilities (#749)
57774ac 
* removed call to ExtensionPointName.create (#749)
* made instantiation of PresentationFactory compatible (#749)
* removed TriConsumer from commons to make build compatible (#749)
* removed deprecated UtilKt.isNull0rEmpty(Collection)(#749)
* removed deprecated EdtInvocationManager.isEventDispatchThread(#749)
* replaced deprecated StructureTreeModel.invalidate()(#749)

Signed-off-by: Andre Dietisheim <[email protected]>
@adietish adietish added IC-2024.1 IC-2022.3 kind/bug Something isn't working labels Apr 17, 2024
@adietish adietish moved this to ✅ Done in IDE Cloudaptors Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adietish adietish

Labels
IC-2022.3 IC-2024.1 kind/bug Something isn't working
Projects
IDE Cloudaptors
Status: ✅ Done
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

fix: make build pass marketplace verification (#749) adietish/intellij-kubernetes
1 participant
@adietish