Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump kuberntes-client to latest kubernetes-client (likely 6.11.0) #668

Open
adietish opened this issue Mar 22, 2024 · 2 comments
Open

bump kuberntes-client to latest kubernetes-client (likely 6.11.0) #668

adietish opened this issue Mar 22, 2024 · 2 comments

Comments

@adietish
Copy link
Contributor

we need to keep track of the evolution of the kubernetes-client and get from 6.4.0 to 6.10+
redhat-developer/intellij-kubernetes#726 very likely requires a bump to the latest, fixed, kubernetes-client.

@adietish adietish self-assigned this Mar 22, 2024
@adietish
Copy link
Contributor Author

Using the new kubernetes-client (tekton-client to be precise) wont work without additional work. Conditions dont exist in 6.10.0 any more.

image

The reasoning seems to be that Conditions were deprecated:
https://github.com/tektoncd/pipeline/blob/v0.16.3/docs/pipelines.md#guard-task-execution-using-conditions

Conditions are deprecated, use WhenExpressions instead.

To me it looks like we need to add support for the new API, we can't simply drop the old one.

If we dont bump to the new client we'd break it once we release intellij-kubernetes, intellij-openshift, intellij-knative, intellij-common with the new client. Users could not install those in parallel. A user could use intellij-tekton alone though.

@adietish
Copy link
Contributor Author

We're decided not to do the work to have the client bumped given the effort required. We lack the required time to resolve it. Contributions highly welcome!

@adietish adietish removed their assignment Mar 22, 2024
adietish added a commit to adietish/intellij-common that referenced this issue Apr 17, 2024
TriConsumer triggers incompatibility warnings in jetbrains marketplace.
intellij-tekton is using it but it cannot bump to latest common version
bcs of the outdated kubernetes-client that it needs to use
(see redhat-developer/intellij-tekton#668).

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to redhat-developer/intellij-common that referenced this issue Apr 17, 2024
TriConsumer triggers incompatibility warnings in jetbrains marketplace.
intellij-tekton is using it but it cannot bump to latest common version
bcs of the outdated kubernetes-client that it needs to use
(see redhat-developer/intellij-tekton#668).

Signed-off-by: Andre Dietisheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant