Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixtures] require skip prefix on skipped files #5079

Merged
merged 4 commits into from
Jan 3, 2021
Merged

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Jan 3, 2021

Based on skip- standardization of non-changing fixtures

Basic Rules

  • if fixture should not be changes, does not have ---- in it, it should start with skip-
  • if the fixture is changed, has-----, it cannot start with skip-

See command from symplify/easy-testing to discover these deprecated-packages/symplify#2733

@TomasVotruba TomasVotruba force-pushed the skip-prefix branch 3 times, most recently from 9429d82 to 366a2cd Compare January 3, 2021 15:38
@TomasVotruba TomasVotruba changed the title skip prefix [fixtures] require skip prefix on skipped files Jan 3, 2021
@TomasVotruba TomasVotruba merged commit 014c019 into master Jan 3, 2021
@TomasVotruba TomasVotruba deleted the skip-prefix branch January 3, 2021 15:54
TomasVotruba added a commit that referenced this pull request Sep 24, 2023
rectorphp/rector-src@bd4c8dd [Performance] Avoid unnecessary IO dumpFile() called when file has no change on FileProcessor (#5079)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant