namespace corrections, skip prefix corrections

.github/workflows/code_analysis.yaml

@@ -33,6 +33,11 @@ jobs:
                         name: Validate Fixtures class name
                         run: bin/rector validate-fixture-classname --ansi
 
+                    # make sure skipped files have "skip_" prefix
+                    -
+                        name: Validate Fixtures skip file prefix
+                        run: vendor/bin/easy-testing validate-fixture-skip-naming rules tests
+
                     -
                         name: 'Validate Sets Loading'
                         # this is very slow, so it has to be in own workflow

composer.json

@@ -185,9 +185,9 @@
             "rules/dead-code/tests/Rector/MethodCall/RemoveDefaultArgumentValueRector/Source/UserDefined.php",
             "rules/naming/tests/ValueObjectFactory/PropertyRenameFactory/Fixture/SomeClass.php.inc",
             "rules/renaming/tests/Rector/FileWithoutNamespace/PseudoNamespaceToNamespaceRector/Source/ChangeMeAnotherNamespace.php",
-            "rules/renaming/tests/Rector/Name/RenameClassRector/Source/ClassImportingSameName.php",
+            "rules/renaming/tests/Rector/Name/RenameClassRector/Source/SkipClassImportingSameName.php",
+            "rules/renaming/tests/Rector/Name/RenameClassRector/Source/SkipSameNamedInterface.php",
             "rules/renaming/tests/Rector/Name/RenameClassRector/Source/Manual_Twig_Filter.php",
-            "rules/renaming/tests/Rector/Name/RenameClassRector/Source/SomeInterface.php",
             "rules/renaming/tests/Rector/Name/RenameClassRector/Source/TwigFilter.php",
             "rules/renaming/tests/Rector/Name/RenameClassRector/Source/Twig_Extension_Sandbox.php",
             "rules/transform/tests/Rector/FuncCall/FuncCallToMethodCallRector/Source/some_view_function.php",

rules/php56/tests/Rector/FunctionLike/AddDefaultValueForUndefinedVariableRector/Fixture/anonymous_function.php.inc → rules/php56/tests/Rector/FunctionLike/AddDefaultValueForUndefinedVariableRector/Fixture/skip_anonymous_function.php.inc

@@ -2,7 +2,7 @@
 
 namespace Rector\Php56\Tests\Rector\FunctionLike\AddDefaultValueForUndefinedVariableRector\Fixture;
 
-class AnonymousFunction
+class SkipAnonymousFunction
 {
     public function run()
     {

rules/php70/tests/Rector/Assign/ListSwapArrayOrderRector/Fixture/skip_empty.php.inc → rules/php70/tests/Rector/Assign/ListSwapArrayOrderRector/Fixture/missing_list_item.php.inc

@@ -2,7 +2,7 @@
 
 namespace Rector\Php70\Tests\Rector\Assign\ListSwapArrayOrderRector\Fixture;
 
-class SkipEmpty
+class MissingListItem
 {
     public function b()
     {
@@ -16,7 +16,7 @@ class SkipEmpty
 
 namespace Rector\Php70\Tests\Rector\Assign\ListSwapArrayOrderRector\Fixture;
 
-class SkipEmpty
+class MissingListItem
 {
     public function b()
     {

rules/php70/tests/Rector/ClassMethod/Php4ConstructorRector/Fixture/in_namespace.php.inc → rules/php70/tests/Rector/ClassMethod/Php4ConstructorRector/Fixture/skip_in_namespace.php.inc

@@ -4,9 +4,9 @@ declare(strict_types=1);
 
 namespace Rector\Php70\Tests\Rector\ClassMethod\Php4ConstructorRector\Fixture;
 
-final class InNamespace
+final class SkipInNamespace
 {
-    public function InNamespacePhp4ConstructorClass()
+    public function SkipInNamespace()
     {
     }
 }

rules/php70/tests/Rector/MethodCall/ThisCallOnStaticMethodToStaticCallRector/Fixture/another_call.php.inc → rules/php70/tests/Rector/MethodCall/ThisCallOnStaticMethodToStaticCallRector/Fixture/skip_another_call.php.inc

@@ -4,7 +4,7 @@ namespace Rector\Php70\Tests\Rector\MethodCall\ThisCallOnStaticMethodToStaticCal
 
 use Rector\Php70\Tests\Rector\MethodCall\ThisCallOnStaticMethodToStaticCallRector\Source\AnotherClass;
 
-class AnotherCall
+class SkipAnotherCall
 {
     public function __construct()
     {

rules/php70/tests/Rector/StaticCall/StaticCallOnNonStaticToInstanceCallRector/Fixture/static_call_on_property.php.inc → rules/php70/tests/Rector/StaticCall/StaticCallOnNonStaticToInstanceCallRector/Fixture/skip_static_call_on_property.php.inc

@@ -4,7 +4,7 @@ namespace Rector\Php70\Tests\Rector\StaticCall\StaticCallOnNonStaticToInstanceCa
 
 use Rector\Php70\Tests\Rector\StaticCall\StaticCallOnNonStaticToInstanceCallRector\Source\WithOnlyStaticMethods;
 
-final class StaticCallOnProperty
+final class SkipStaticCallOnProperty
 {
     /**
      * @var WithOnlyStaticMethods

rules/php71/tests/Rector/BinaryOp/BinaryOpBetweenNumberAndStringRector/Fixture/ignore_concatenation_dot.php.inc → rules/php71/tests/Rector/BinaryOp/BinaryOpBetweenNumberAndStringRector/Fixture/skip_concatenation_dot.php.inc

@@ -2,7 +2,7 @@
 
 namespace Rector\Php71\Tests\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector\Fixture;
 
-class IgnoreConcatenationDot
+final class SkipConcatenationDot
 {
     public function run()
     {

rules/php71/tests/Rector/FuncCall/CountOnNullRector/Fixture/skip_countable_annotated_params.php.inc

@@ -0,0 +1,43 @@
+<?php
+
+namespace Rector\Php71\Tests\Rector\FuncCall\CountOnNullRector\Fixture;
+
+class SkipCountableAnnotatedParams
+{
+    function a(array $a = [])
+    {
+        count($a);
+    }
+
+    /**
+     * @param array $b
+     */
+    function b($b = [])
+    {
+        count($b);
+    }
+
+    /**
+     * @param array $c
+     */
+    function c($c)
+    {
+        count($c);
+    }
+
+    /**
+     * @param mixed[] $d
+     */
+    function d($d)
+    {
+        count($d);
+    }
+
+    /**
+     * @param string[] $e
+     */
+    function e($e)
+    {
+        count($e);
+    }
+}

rules/php71/tests/Rector/FuncCall/CountOnNullRector/Fixture/skip_countable_class.php.inc

@@ -0,0 +1,17 @@
+<?php
+
+namespace Rector\Php71\Tests\Rector\FuncCall\CountOnNullRector\Fixture;
+
+use Rector\Php71\Tests\Rector\FuncCall\CountOnNullRector\Source\CountableClass;
+
+class SkipCountableClass
+{
+    public function run()
+    {
+        $values = [];
+        $count = count($values);
+
+        $values = new CountableClass();
+        $count = count($values);
+    }
+}

rules/php71/tests/Rector/FuncCall/CountOnNullRector/Fixture/skip_double_same_variable.php.inc

@@ -0,0 +1,32 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Php71\Tests\Rector\FuncCall\CountOnNullRector\Fixture;
+
+class SkipDoubleSameVariable
+{
+    public function run()
+    {
+        $fn = function() {
+            $primaryColumns = Dibi::getColumns();
+
+            if (count($primaryColumns) === 0) {
+                throw new \Exception("x");
+            }
+
+            if (count($primaryColumns) > 1) {
+                throw new \Exception("y");
+            }
+        };
+    }
+}
+
+
+class Dibi
+{
+    public static function getColumns(): array
+    {
+        return [];
+    }
+}

rules/php71/tests/Rector/FuncCall/CountOnNullRector/Fixture/skip_external_property.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Php71\Tests\Rector\FuncCall\CountOnNullRector\Fixture;
+
+use PhpParser\Node\Expr\Isset_;
+
+class SkipExternalProperty
+{
+    public function run()
+    {
+        $issetNode = new Isset_([]);
+
+        if (! isset($issetNode->vars[0]) || count($issetNode->vars) > 1) {
+        }
+    }
+}

rules/php71/tests/Rector/FuncCall/CountOnNullRector/Fixture/skip_preg_match_array.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+// @covers https://github.com/rectorphp/rector/issues/786
+
+namespace Rector\Php71\Tests\Rector\FuncCall\CountOnNullRector\Fixture;
+
+class SkipPregMatchArray
+{
+    function pregMatchArray()
+    {
+        $version = 'hi';
+        preg_match('#\d\.\d(\.\d)?(-?\S*)?#i', $version, $matches);
+
+        if (count($matches) > 0) {
+            return 'found';
+        }
+
+        preg_match_all('#\d\.\d(\.\d)?(-?\S*)?#i', $version, $matches);
+
+        if (count($matches) > 0) {
+            return 'found';
+        }
+
+        return 'none';
+    }
+}

rules/php71/tests/Rector/FuncCall/CountOnNullRector/Fixture/property_within_trait_method.php.inc → rules/php71/tests/Rector/FuncCall/CountOnNullRector/Fixture/skip_property_within_trait_method.php.inc

@@ -2,7 +2,7 @@
 
 namespace Rector\Php71\Tests\Rector\FuncCall\CountOnNullRector\Fixture;
 
-trait PropertyWithinTraitMethod
+trait SkipPropertyWithinTraitMethod
 {
     /**
      * @var array

rules/php71/tests/Rector/FuncCall/CountOnNullRector/Fixture/variable_within_trait_method.php.inc → rules/php71/tests/Rector/FuncCall/CountOnNullRector/Fixture/skip_variable_within_trait_method.php.inc

@@ -2,9 +2,7 @@
 
 namespace Rector\Php71\Tests\Rector\FuncCall\CountOnNullRector\Fixture;
 
-use Rector\Php71\Tests\Rector\FuncCall\CountOnNullRector\Source\CountableClass;
-
-class SomeClassUsingTrait
+class SkipVariableWithintTraitMethod
 {
     use VariableWithinTraitMethod;
 }