Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixtures] require "skip_" prefix on skipped files #5080

Closed
TomasVotruba opened this issue Jan 3, 2021 · 3 comments
Closed

[fixtures] require "skip_" prefix on skipped files #5080

TomasVotruba opened this issue Jan 3, 2021 · 3 comments
Assignees
Labels

Comments

@TomasVotruba
Copy link
Member

TomasVotruba commented Jan 3, 2021

Based on skip- standardization of non-changing fixtures

Basic Rules

  • if fixture should not be changes, does not have ---- in it, it should start with skip-
  • if the fixture is changed, has-----, it cannot start with skip-

This is manual case by case work.


There was 190 cases in the start, 1/3 of the work has been done in: #5079, check there for inspiration how it should be handled

To discovery invalid cases, uncomment following from .github/workflows/code_analysis.yaml:

                    # make sure skipped files have "skip_" prefix
#                    -
#                        name: Validate Fixtures skip file prefix
#                        run: vendor/bin/easy-testing validate-fixture-skip-naming rules tests
@TomasVotruba
Copy link
Member Author

Could you check this one as next? It's mostly test fixture file renaming

@samsonasik
Copy link
Member

I will try

@samsonasik
Copy link
Member

closing as implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants