-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix notebook build failure on Spark 3.2 #1608
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@miguelgfierro This PR looks good now. The error below appears when running on Spark 3.2. According to the instructions in the error, I set to
The error can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Codecov Report
@@ Coverage Diff @@
## staging #1608 +/- ##
============================================
+ Coverage 0.00% 58.22% +58.22%
============================================
Files 84 84
Lines 8462 8462
============================================
+ Hits 0 4927 +4927
- Misses 0 3535 +3535
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Description
Spark 3.2 introduces breaking changes that make code written for Spark version below 3.2 incompatible. This PR modified the notebook to be compatible with Spark 3.2. The dependency that are affected is MMLSpark which is now renamed to SynapseML.
However, the latest SynapseML (SynapseML 0.9.5) do not support Spark version below 3.2. To use Spark 3.0 and 3.1, SynapseML 0.9.4 should be used. This difference is also pointed out in the comments of mmlspark_lightgbm_criteo.ipynb.
Related Issues
See #1553
Checklist:
staging branch
and not tomain branch
.