Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Error on als_movielens.ipynb #1614

Closed
Seyoung9304 opened this issue Jan 19, 2022 · 2 comments
Closed

[BUG] Error on als_movielens.ipynb #1614

Seyoung9304 opened this issue Jan 19, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@Seyoung9304
Copy link

Seyoung9304 commented Jan 19, 2022

Description

Hello :)
I found two bugs on ALS Tutorial.

1. Error at data = movielens.load_spark_df(spark, size=MOVIELENS_DATA_SIZE, schema=schema)

This occurs when I use pyspark==2.3.1.
I used pyspark==2.3.1 because tutorial was based on this version,
but it fails.
But when I use pyspark==3.2.0, it works.

image

2. Join operation fail at

dfs_pred_exclude_train = dfs_pred.alias("pred").join(
        train.alias("train"),
        (dfs_pred[COL_USER] == train[COL_USER]) & (dfs_pred[COL_ITEM] == train[COL_ITEM]),
        how='outer'
    )

As version 2.3.1 fails, I tried this with pyspark==3.2.0.
However, AnalysisException occurs.
image
I think this is also a version issue.

In which platform does it happen?

  • Google Colab
  • System version: 3.7.12 (GCC 7.5.0)
  • Spark version: 2.3.1, 3.2.0

How do we replicate the issue?

Run https://github.com/microsoft/recommenders/blob/main/examples/00_quick_start/als_movielens.ipynb on Colab

Expected behavior (i.e. solution)

Version issues should be resolved.
Join operations should be done without error.

Other Comments

Thank you in advance! :)

@Seyoung9304 Seyoung9304 added the bug Something isn't working label Jan 19, 2022
@miguelgfierro
Copy link
Collaborator

@Seyoung9304 it might be related to this fix we did #1608?

Can you try staging branch and run again?

FYI @simonzhaoms

@Seyoung9304
Copy link
Author

Hello!
Now it is working! Thank you so much 👍👍👍
Have a great day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants