Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not emit empty data events #108

Merged
merged 1 commit into from
Feb 11, 2017
Merged

Do not emit empty data events #108

merged 1 commit into from
Feb 11, 2017

Conversation

clue
Copy link
Member

@clue clue commented Feb 10, 2017

Refs #104

@clue clue added this to the v0.4.4 milestone Feb 10, 2017
@clue clue mentioned this pull request Feb 10, 2017
Closed
@WyriHaximus WyriHaximus requested a review from jsor February 10, 2017 18:57
@WyriHaximus
Copy link
Member

@clue could you resolve conflicts? Otherwise good to merge 👍

@clue
Copy link
Member Author

clue commented Feb 11, 2017

Rebased now that #110 is in :shipit:

@WyriHaximus
Copy link
Member

Cheers 👍

@WyriHaximus WyriHaximus merged commit 53ec1f0 into reactphp:master Feb 11, 2017
@clue clue deleted the data-event branch February 11, 2017 14:25
@clue clue mentioned this pull request Feb 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@jsor jsor jsor approved these changes

Assignees
No one assigned
Labels
bug easy pick
Projects
None yet
Milestone
v0.4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@clue @WyriHaximus @jsor