Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore empty writes to not mess up chunked transfer encoding #112

Merged
merged 1 commit into from
Feb 11, 2017
Merged

Ignore empty writes to not mess up chunked transfer encoding #112

merged 1 commit into from
Feb 11, 2017

Conversation

clue
Copy link
Member

@clue clue commented Feb 11, 2017

Builds on top of #108.

@clue clue added this to the v0.4.4 milestone Feb 11, 2017
WyriHaximus
WyriHaximus approved these changes Feb 11, 2017
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this would indeed cause problems 👍

@WyriHaximus WyriHaximus requested a review from jsor February 11, 2017 14:41
@WyriHaximus WyriHaximus merged commit 92d4f52 into reactphp:master Feb 11, 2017
@clue clue deleted the empty-write branch February 11, 2017 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@jsor jsor jsor approved these changes

Assignees
No one assigned
Labels
bug easy pick
Projects
None yet
Milestone
v0.4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@clue @jsor @WyriHaximus