Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support detecting request body #104

Closed
clue opened this issue Feb 10, 2017 · 3 comments
Closed

Support detecting request body #104

clue opened this issue Feb 10, 2017 · 3 comments
Assignees
Milestone

Comments

@clue
Copy link
Member

clue commented Feb 10, 2017

Proper detection of request message bodies requires:

See https://tools.ietf.org/html/rfc7230#section-3.3

This means that we should take these into account and only emit data events for what is actually part of the given request and then emit an end and close event.

This is also a prerequisite for #39.

@WyriHaximus
Copy link
Member

While seeing all the prerequisites are met, doesn't this make more sense to come in 0.8?

@clue
Copy link
Member Author

clue commented Feb 24, 2017

This PR only handles detecting the message body, i.e. emitting streaming data, end, error and close events. Afaict this is not handled for all cases yet (requests with implicit message lengths). Once everything is completed, this should be released as v0.6.0.

This ticket does not handle parsing this message body, this is left up for #105. Parsing the body relies on detecting its length first (this ticket) and likely also on adding a proper interface first (#28), so this is currently planned for the v0.8.0 release.

@clue
Copy link
Member Author

clue commented Mar 7, 2017

Closed via #116, #129, #130, #136 and #137. Example added via #139.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants