Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support detecting response body boundaries #136

Closed
clue opened this issue Sep 6, 2018 · 1 comment
Closed

Support detecting response body boundaries #136

clue opened this issue Sep 6, 2018 · 1 comment

Comments

@clue
Copy link
Member

clue commented Sep 6, 2018

Proper detection of request message bodies requires:

See https://tools.ietf.org/html/rfc7230#section-3.3

This means that we should take these into account and only emit data events for what is actually part of the given response and then emit an end and close event.

This is also a prerequisite for #39 and #41.
This feature is similar to the server side (reactphp/http#104 and #78).

@clue
Copy link
Member Author

clue commented Jul 13, 2020

I'm closing this as it is already supported by the new HTTP client that has been merged into react/http via reactphp/http#368 :shipit: You should upgrade as per #152 👍

@clue clue closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant