Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge into Http component and deprecate HttpClient component #78

Closed
clue opened this issue Mar 19, 2017 · 6 comments
Closed

Merge into Http component and deprecate HttpClient component #78

clue opened this issue Mar 19, 2017 · 6 comments

Comments

@clue
Copy link
Member

clue commented Mar 19, 2017

Opening this for the reference and to raise awareness. Note that there's an ongoing discussion as to whether this component should be merged into the Http component.

See reactphp/http#148 for details.

@andig
Copy link

andig commented May 5, 2017

I'm currently looking into this and am a bit stumped on how to convert a Psr StreamInterface into a react ReadableStream.

To be more precise I'm trying to use ringcentral StreamWrapper::getResource() to convert from StreamInterface into ReadableStream which fails:

PHP Warning:  stream_set_blocking(): RingCentral\Psr7\StreamWrapper::stream_set_option is not implemented! in /Users/andig/Documents/htdocs/react-http-client/vendor/react/stream/src/Stream.php on line 43

Any ideas? Either this is not an "easy pick" or just beyond my skills :/

@clue
Copy link
Member Author

clue commented May 5, 2017

@andig It sounds like this might be related to #41 instead of this ticket? It's my understanding that #41 has priority first and once that's addressed, merging the two components should be an easy pick :shipit:

@andig
Copy link

andig commented May 5, 2017

@clue thank you. I didn't realize there was already work going on. Better letting you guys do your magic :)

@mdrost
Copy link
Contributor

mdrost commented Jun 17, 2017

Is it possible that when this components will be merged into react/http then this repository could become something like react version of GuzzleHttp with all Psr7 goodies (better version of clue/php-react-buzz)?

@WyriHaximus
Copy link
Member

Define

all Psr7 goodies

and

better version of clue/php-react-buzz

cause not sure what exactly you're looking for 😉

@clue
Copy link
Member Author

clue commented Jul 12, 2020

Superseded and closed via reactphp/http#368 / #152 :shipit:

@clue clue closed this as completed Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants