Fix chunk header to be case-insensitive and allow leading zeros for end chunk

[mdrost]

No description provided.

[clue]

@mdrost Thanks for filing this PR! It looks like your PR fixes a real bug (uppercase chunk header), but it also changes quite a bit of code that appears to be unrelated to this, so I wonder if you can give us some background here or update this to only change related code. Thanks!

[clue]

Also ping @legionth, is this also relevant for react/http?

[mdrost]

After fixing uppercase chunk header Wizzair site from #76 still throws exception. Wizzair terminating chunk contains 8 zeros but ChunkedStreamDecoder only looks for 1 zero.

[WyriHaximus]

Also ping @legionth, is this also relevant for react/http?

I think it is, will file a PR later today 👍 .

[legionth]

@clue @WyriHaximus I'm currently not on my development system. I think this line: https://github.com/reactphp/http/blob/master/src/ChunkedDecoder.php#L103
Should take care of this.
At least there are missing tests in react/http for this behavior.

[mdrost]

Shouldn't it be better to have only one chunked decoder? 🤕

[WyriHaximus]

@mdrost We have plans for that

[WyriHaximus]

@mdrost for reference #78

[clue]

Thanks for this PR and your quick response, the changes LGTM 👍

For the reference: This builds on top of #73, #71, #68, #67 and #58.