Ensure checking for 0 length chunk, when we should check for it #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fore attempting to extract the length. As the final one will always be zero. Also force one final iteration over the buffer when handling end
clue
approved these changes
Dec 2, 2016
| @@ -87,6 +87,14 @@ protected function iterateBuffer() | |||
| } | |||
|
|
|||
| if ($this->nextChunkIsLength) { | |||
| if (substr($this->buffer, 0, 3) === "0\r\n") { | |||
There was a problem hiding this comment.
IMO it would be cleaner to parse this like a normal chunk header in order to support chunk extensions etc. as usual. But I guess this is good as-is because it already fixes a particular bug, so let's get this in first 👍
There was a problem hiding this comment.
Tests already check for end of body extensions: https://github.com/WyriHaximus/http-client/blob/26f43a22e23cc8dc879bbee0c392bbd56b1ce023/tests/DecodeChunkedStreamTest.php#L145 But does it could be a bit better, lets try to get that into v0.4.16, I'll get this out the door in v0.4.15.
jsor
approved these changes
Dec 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67 (for the third time 🤐 )
The problem occurs when the last bit in the buffer is
0\r\n. Because we parse the length chunk and conclude it is zero thus clearing the buffer before checking for the end we never find the end. By moving that check to before parsing the length chunk we correctly find the end