Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Answer with HTTP/1.0 until 1.1 is really implemented #12

Closed
wants to merge 1 commit into from
Closed

Answer with HTTP/1.0 until 1.1 is really implemented #12

wants to merge 1 commit into from

Conversation

nicolas-grekas
Copy link

Currently, the HTTP server answers with 1.1 but does not handle persistent connexions.
Because of this, well behaving clients, expecting proper handling of the advertised 1.1 semantic do not work:
the incoming Request object does never trigger the end event.
This of course is because an HTTP/1.1 client never closes the socket connexion.

@nicolas-grekas
Copy link
Author

Just as a side note, my use case is receiving an HTTP query with Transfert-Encoding: chunked from a regular Go HTTP client

@clue
Copy link
Member

clue commented Sep 13, 2016

What is the status of this PR?

Does this really fix any bugs? If so, can we add some test cases to confirm this?

FWIW, chunked transfer encoding is currently being implemented by @WyriHaximus here: reactphp/http-client#58

@clue
Copy link
Member

clue commented Feb 10, 2017

Thanks for filing this PR @nicolas-grekas! 👍

I think this addresses a real issue, but I'd rather address the end event via #104 and chunked transfer encoding via #96.

This is kind of an old PR and it contains plenty of merge conflicts now. Unfortunately, this hasn't been updated in years, so I'll close this due to a lack of feedback. If you think this is still worth addressing, please update this PR or file a new one and we can reconsider this 👍

@clue clue closed this Feb 10, 2017
@clue
Copy link
Member

clue commented Feb 19, 2017

For the reference: Persistent connections will be addressed via #39 (eventually), but I'll look into explicitly denying persistent connection support for HTTP/1.1 clients in the meantime 👍

@clue
Copy link
Member

clue commented Feb 19, 2017

The issues you were seeing should now be addressed via #128.

I hope this helps 👍

@nicolas-grekas
Copy link
Author

not sure about that: the client sends chunked encoding in my case.

@clue
Copy link
Member

clue commented Feb 19, 2017

Incoming chunked transfer encoding will now be decoded via #116 :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants