-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8 support #89
Comments
Have you tried |
Thank you for the response, of course ignoring the php version it works, but I think:
|
@cheeghi since those are my packages I'll have a look at adding PHP8 support |
@WyriHaximus Ok thanks |
@cheeghi FYI I haven't forgotten about this and updated a lot of the underlying packages to support PHP 8. There are 3 left to do, two of them do all the messaging and pooling, I'll tag a release that adds the most bare PHP 8 support possible, and do a major release that fully supports PHP 7 features and also works on PHP 8. |
@WyriHaximus Thanks for the info, I can imagine there's some work to do, hope can be released soon! |
@cheeghi The packages done so far are significantly smaller, 2/3 of what is left is a lot bigger so using a different short term strategy for them. |
@WyriHaximus in #89 (comment) you mention a "bare minimum version that works on PHP 8", is that something I can find here: https://github.com/WyriHaximus/reactphp-child-process-pool ? |
@holtkamp So https://github.com/WyriHaximus/reactphp-child-process-pool relies on https://github.com/WyriHaximus/reactphp-child-process-messenger and that doesn't work on PHP 8 yet |
I was able to install this into DiscordPHP by using --ignore-platform-reqs in composer and was able to get some functionality working, but most things will either fail silently or throw a 500 internal server error. Most notably with PHP 8 changes, Windows stills seems to have issues with pipes but can use stdio sockets to achieve similar results. |
@valzargaming Yeah which is why https://github.com/WyriHaximus/reactphp-child-process-messenger uses TCP sockets to communicate with the child processes. Anyway, about to round off work around a set of my ReactPHP packages today. Picking up related packages for this after that, the messenger package is going to be fun 🤐 . |
@cheeghi Thanks for bringing this up! I'm currently in the process of updating the test suites for all ReactPHP component and will add PHP 8 as a test target along the way 👍 We've verified PHP 8 works fine for most components via manual tests (e.g. reactphp/http#391), but couldn't add this to our CI setup due to a lack of support in Travis. I'll address this as soon as reactphp/reactphp#442 is merged, so this is definitely in the works and shouldn't take too long before everything is in On top of this, this project currently depends on a few external libraries maintained by others. @WyriHaximus already pointed out he's working on an update these, looking forward to an update 👍 Additionally, we're in the process of reworking this project's API (#46 and #90), so there's hope we will be able to simplify this somewhat and also support more platforms in the future 👍 |
An update on this, since this weekend I've been spending an hour a day or more working on updating https://github.com/WyriHaximus/reactphp-child-process-messenger to PHP 7.4 and to get it working on PHP 8. FYI releases will be done in such a way there is no new release required on |
@WyriHaximus any update so far? |
@isfar Almost there, this is the last piece: WyriHaximus/reactphp-child-process-pool#57 (comment) |
FYI I'm aware and looking into which angle to fix this from: WyriHaximus/reactphp-child-process-pool#69 (comment) |
Just did a few releases resolving this issue. Please reopen this issue if it somehow persists for you. |
I'm trying to use react/filesystem with PHP 8:
But on composer install I got:
It seems that the transitive dependency wyrihaximus/react-child-process-pool can't be used with PHP 8.
Do you have any plan on supporting PHP 8? Thanks.
The text was updated successfully, but these errors were encountered: