Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello PHP 8 ! #57

Closed
GothShoot opened this issue Feb 19, 2021 · 11 comments
Closed

Hello PHP 8 ! #57

GothShoot opened this issue Feb 19, 2021 · 11 comments

Comments

@GothShoot
Copy link

Hello,

Can you have a plan to php 8 support ?

I see you use wyrihaximus/react-child-process-messenger but it use cakephp without support of php 8. :(

Tank's for considering this issue, because one of my project use lot of async task and i plan to use php 8.

@WyriHaximus
Copy link
Owner

Yes, but first https://github.com/WyriHaximus/reactphp-child-process-messenger needs to support PHP 8 and I'm working on that at the moment. The problem isn't the CakePHP package, it just doesn't work at all on PHP 8 🤐 .

@GothShoot
Copy link
Author

What is the use of CakePHP in your other lib ?

@GothShoot
Copy link
Author

I have seen your master try to use v4 of CakePHP, but is probably not working ?

@WyriHaximus
Copy link
Owner

What is the use of CakePHP in your other lib ?

It's using the Hash class for some conversion.

I have seen your master try to use v4 of CakePHP, but is probably not working ?

It's all working on PHP 7.4, but not yet on PHP 8. Why do you think the use of CakePHP is problematic?

@GothShoot
Copy link
Author

GothShoot commented Feb 19, 2021

What is the use of CakePHP in your other lib ?

It's using the Hash class for some conversion.

Okay 🤔

I have seen your master try to use v4 of CakePHP, but is probably not working ?

It's all working on PHP 7.4, but not yet on PHP 8. Why do you think the use of CakePHP is problematic?

Just a question. Do you think CakePHP be compatible rapidly? I'm don't at ease with it

@WyriHaximus
Copy link
Owner

What is the use of CakePHP in your other lib ?

It's using the Hash class for some conversion.

Okay

It's been a while, essentially IIRC it deflates and inflates arrays to lines and back.

I have seen your master try to use v4 of CakePHP, but is probably not working ?

It's all working on PHP 7.4, but not yet on PHP 8. Why do you think the use of CakePHP is problematic?

Just a question. Do you think CakePHP be compatible rapidly? I'm don't at ease with it

Ow they will, I'm not to worried about that. However since the master branch will become a new major version it can be replaced with something that does the same. Looking at the cakephp composer.json it's PHP targeting suggests it supports 8.

@GothShoot
Copy link
Author

Thank's, I patient to see an update for PHP 8 (my pipeline already test with allow_fail).

@GothShoot
Copy link
Author

Any more possility to use PHP 8 ?

@WyriHaximus
Copy link
Owner

As good as done, only thing to complete is #58 and then it's a matter of tagging a few releases. My only issue is that the tests are flaky, so I might have missed something along the line 🤐

@GothShoot
Copy link
Author

Good 😄 Please tell me where you fix the last thing !

@WyriHaximus
Copy link
Owner

Just did a few releases resolving this issue. Please reopen this issue if it somehow persists for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants