-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fixed] Custom classnames override default styles #100
[fixed] Custom classnames override default styles #100
Conversation
This makes it so if you provide a custom className it will override all the default styling, relying solely on the style props you pass in and the className itself. Prior to this commit, providing a className or overlayClassName doesn't really have any effect because the style attribute has higher precedent when applying styles.
👍 |
@mzabriskie Your thoughts? |
👍 |
I've been using this for a bit now... the only caveat that I've come across is that no default styles get applied... so you need to pass in the the default styles that may/may not matter to you into the styles prop when creating the modal. |
Wouldn't it be better to just have a prop, say |
@chielkunkels So this approach doesn't attempt to disable default styles (or at least that's not the end goal). It is to make it so that class names have some value again. The current implementation on master completely relies on the inline styles that are passed in. Because of style precedence however, styles from class names are never applied. Disabling the default styles just happens to be a byproduct of this approach. It's not the intention of the PR though. |
👍 @mzabriskie is this good to merge? |
👍 @mzabriskie this would be huge. |
👍 @mzabriskie would be so pumped on this. |
What is the status of this PR? Is there anything holding it up? |
Is this project dead, why aren't solid PR's getting merged in? |
+1, thank you! Can we get npm version? |
@aarosil I'm hoping to get an npm version pushed out by the end of the week. I'm hoping to get as many PRs merged in and issues closed before cutting the release. So I'm hoping that the end of the week will give me enough time to take care of most of the current backlog. |
This makes it so if you provide a custom className it will override
all the default styling, relying solely on the style props you pass
in and the className itself.
Prior to this commit, providing a className or overlayClassName
doesn't really have any effect because the style attribute has higher
precedent when applying styles.