-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Default Styles? #97
Comments
+1 this would be very useful. I would like to just position the elements using flexbox properties. |
I was about to create an issue for the same thing. Only, I was going to create the issue as a suggestion to add this to docs:
This works -- any style set to |
@ericsoco It would be useful to have that in the docs, but it is quite annoying to have to override every single property for the content and the background if I want to use classes. |
I'd love to see this, at the moment as a temp fix I have all the relevant styles set to null individually
|
Yep, @ericsoco's workaround worked for me. If anyone's interested, these are the styles I'm using to have flexbox position the modal:: |
@idmontie agreed. I have this in my code now:
And that's a little ridiculous. |
We should write:
|
agreed |
@ericsoco 👍 I can't understand why defaults are enforced like this |
+1 |
Just opened another issue but then saw this one that is basically asking the same question. Having to turn off every style seems a little ridiculous and can be breaking if new "default" styles are added. Would prefer to just turn them off and work within CSS. |
+1 Also as I see here https://github.com/reactjs/react-modal/blob/master/lib/components/ModalPortal.js#L183 you disable default styles if there are class names. But it doesn't work in latest(0.6.1) npm and bower lib version. Could you please publish latest master code to npm and bower? |
@dzmitry-kremez-itechart I'm working on finalizing a few details with the new release. It will happen soon, hopefully this week. |
@claydiffrient cool, thx |
v1.0.0 was just published and classnames can override defaults now. |
Is there a way to completely disable the default styles?
I was hoping I could just use:
But,
_.assign
will just ignore thefalse
value.The text was updated successfully, but these errors were encountered: