-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
classNames #95
Comments
👍 |
+1 please bring back classNames. Its a pain to do custom animations with inline-styles that can't be overwritten with css. |
👍 |
For those that are interested I've started a separate project |
👍 |
Seems like very little effort to support both. 👍 |
👍 |
Looks like #100 would fix this, but it hasn't been reviewed/merged yet. |
v1.0.0 is now released with supported added back for classNames |
I see that
react-modal
used to have the ability to specify classes for styles but that was removed in favor of inline styles.While some might argue that inline styles are better for react applications, not everyone has that option (including myself).
It would be nice if
react-modal
wasn't opinionated about this and supported both giving classNames and inline styles.The text was updated successfully, but these errors were encountered: