Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classNames #95

Closed
jamiebuilds opened this issue Nov 2, 2015 · 9 comments
Closed

classNames #95

jamiebuilds opened this issue Nov 2, 2015 · 9 comments

Comments

@jamiebuilds
Copy link

I see that react-modal used to have the ability to specify classes for styles but that was removed in favor of inline styles.

While some might argue that inline styles are better for react applications, not everyone has that option (including myself).

It would be nice if react-modal wasn't opinionated about this and supported both giving classNames and inline styles.

@paazmaya
Copy link

paazmaya commented Nov 4, 2015

👍

@nbwar
Copy link

nbwar commented Nov 4, 2015

+1 please bring back classNames. Its a pain to do custom animations with inline-styles that can't be overwritten with css.

@idmontie
Copy link

idmontie commented Nov 4, 2015

👍

@jamiebuilds
Copy link
Author

For those that are interested I've started a separate project react-modal2 which is less opinionated, accessible, stateless (dumb component), and is built via a reusable collection of modules. It also allows you to use classNames instead of inline styles.

@kjs3
Copy link

kjs3 commented Nov 19, 2015

👍

@OKNoah
Copy link

OKNoah commented Nov 21, 2015

Seems like very little effort to support both. 👍

@antoinerey
Copy link

👍

@simpixelated
Copy link

Looks like #100 would fix this, but it hasn't been reviewed/merged yet.

@claydiffrient
Copy link
Contributor

v1.0.0 is now released with supported added back for classNames

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants