-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove json patch #881
remove json patch #881
Conversation
44e1514
to
f2f665e
Compare
@Archmonger, at the moment, this change proposes that all messages between the server and client contain a {
"type": "layout-event",
...
} This anticipates the possibility of a message routing system that components could hook into. For example, the following could be possible in the future: @component
def Example():
messenger = use_messenger(receives="custom-recv-type", sends="custom-send-type")
@use_effect
async def message_receiver():
while True:
inbound = await messenger.receive()
...
await messenger.send(outbound)
... My thinking with the single
I'm open to alternatives though. For example, adding a |
f2f665e
to
5461add
Compare
I support this configuration. However, I don't support encoding the version into the type string ( I would suggestion this format {
"type": "layout-event",
"version": 1, # `version` should be optional. If undefined, assume latest version of the API.
...
} |
427f306
to
60f8d5a
Compare
60f8d5a
to
6938a6e
Compare
closes: #877
Checklist
Please update this checklist as you complete each item:
changelog.rst
has been updated with any significant changes.