Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communicate Javascript console output as Python logging #890

Open
Archmonger opened this issue Jan 27, 2023 · 3 comments
Open

Communicate Javascript console output as Python logging #890

Archmonger opened this issue Jan 27, 2023 · 3 comments
Labels
priority-3-low May be resolved one any timeline. type-feature About new capabilities

Comments

@Archmonger
Copy link
Contributor

Archmonger commented Jan 27, 2023

Current Situation

Javascript warnings and exceptions are currently not visible within the Python console. This feels fairly fragmented, as Python developers won't expect to check the client side console for warnings/errors.

Proposed Actions

By using our new messaging schema, all client-sided console output should be redirected to the server and logged the within the Python console.

This should only occur when ReactPy is in debug mode.

Related:

@Archmonger Archmonger added type-feature About new capabilities priority-3-low May be resolved one any timeline. labels Jan 27, 2023
@Archmonger Archmonger added this to the 2.0 milestone Jan 27, 2023
@rmorshea
Copy link
Collaborator

As noted in the linked comment, the messaging scheme (as it stands today) only anticipates a message routing system. It would be useful to write up a task for actually implementing that routing system since this issue would depend upon it.

@rmorshea rmorshea removed this from the Luxury milestone Feb 21, 2023
@Archmonger
Copy link
Contributor Author

@rmorshea This issue has reminded me that we probably want to flesh this out soon.

It's going to be confusing as hell to new users that class is class_name, especially given that there's zero server side indication of such.

@rmorshea
Copy link
Collaborator

Yup. I actually completely forgot about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-low May be resolved one any timeline. type-feature About new capabilities
Projects
None yet
Development

No branches or pull requests

2 participants