Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot update the root element. #498

Closed
1 of 2 tasks
rmorshea opened this issue Sep 3, 2021 · 1 comment · Fixed by #881
Closed
1 of 2 tasks

Cannot update the root element. #498

rmorshea opened this issue Sep 3, 2021 · 1 comment · Fixed by #881
Labels
priority-3-low May be resolved one any timeline. type-bug About something that isn't working
Milestone

Comments

@rmorshea
Copy link
Collaborator

rmorshea commented Sep 3, 2021

Current Situation

The 0.33.0 release introduced a regression in which the root element of the layout cannot be updated due to a typo on this line where doc should have been doc.current. We missed this during testing because, under the hood, the display() test fixture uses hotswap under the hood which always modifies one of its children (not the root element). We need an explicit test to check that the root element can be udpated.

Proposed Changes

  • quickly fix the issue and make a 0.33.1 release.
  • add a regression test to ensure this doesn't happen again in the future.

Implementation Details

No response

@rmorshea rmorshea added flag-triage Not prioritized. type-bug About something that isn't working and removed flag-triage Not prioritized. labels Sep 3, 2021
@rmorshea rmorshea closed this as completed Sep 9, 2021
@rmorshea rmorshea reopened this Sep 9, 2021
@rmorshea rmorshea added this to the 1.0 milestone Jan 11, 2022
@rmorshea rmorshea added the priority-2-moderate Should be resolved on a reasonable timeline. label Jan 13, 2022
@rmorshea rmorshea added priority-3-low May be resolved one any timeline. and removed priority-2-moderate Should be resolved on a reasonable timeline. labels Mar 28, 2022
@rmorshea
Copy link
Collaborator Author

If I remove json-patch as part of 1.0 I think I can just ignore this altogether.

@Archmonger Archmonger linked a pull request Jan 22, 2023 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-low May be resolved one any timeline. type-bug About something that isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant