Release 18 #1516
Merged
Release 18 #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added email templates package Added ability to register html and react templates with new helper Reaction.registerTemplate. * Schema updates and render render functions Added handlebars render functions, as well as the ability to register a custom template renderer. Added caching for handlebars templates. Updated templates schema with more properties. * Updated tests and template registration functionality * add handlebars
Fixed import of "Import" module. Fixed type in jsDoc comments for "Import.template" function.
* Register all email templates * Fetch email templates from database * Add helper to get email template file without any extra dependencies * Update method for fetching email template file * Fix template paths * Re-added missing comment * Fixed path to core order "new" email template
* added some comments to break up html table * reorganized data for email template removed all [0]. type variables from new.html email template, so all variables are set in orders.js for easy manipulation * welcome to the shop email template * extract social from template, add on/off switch * invite shop member email * shopName variable updates * update reaction address This was driving me crazy seeing the wrong address in all these emails being tested. * add Collections imports for Accounts, Cart, Shopts * password reset emails * update subject of order confirmation email * lint fix * renamed file for email template * removed test text
Will take care of `WARN Reaction: Template not found: accounts/reset_password. Falling back to coreDefault.html` error
* discount skeleton
- remove from core
- add core/discounts
- add discounts-rates
- add discount-codes
- new discount schemas [WIP]
* local module import of translations
- adds `loadTranslations` and `loadTranslation` methods
- removes necessity to add translations to core
- `import { loadTranslations } from "/server/startup/i18n”;`
- multiple file import illustrated in reaction-taxes
- single import illustrated in reaction-discounts
- introduces mergeDeep helper in i18n/startup and updates to
translation resource structure to accommodate additional
namespaces for package (uses package name).
* updated i18n namespace and handling
- add i18n handling for griddle column headers
- add local i18n imports to discounts
- updated i18n taxSettings namespace (into packages + admin)
* change info logging to debug
* schemas, forms, ui, i18n for discount modules
* updated Discount schemas
- implement client collections for DiscountCodes, DiscountRates
- implement multi-schema on server Discounts collection
* updated discounts pub
- split security out
* Meteor 1.4.2.1
updated to Meteor 1.4.2.1.
* group payments packages
- resolves #1408
- consolidates all payment packages into a single admin group
- rename include payment package folders `payment-`
- add initial local i18n, moved from en.json (TODO, other lang).
- move “default method” setting from shop to new `core/payments`
package.
- move checkout/payment templates from core to `core/payments` package.
- expose icon in public registry
* Build product detail page from JS object * Allow for nested blocks, custom styling. Removed old code. Added default columns of 12 if block columns not specified. * Fix responsive image issues in media gallery * Fix pdp add to cart button styles * ReactionLayout for react Moved layout generator to "layout" core module. Added permission check for top level blocks. * Permissions for components in React ReactionLayout renderer * Pass ProductDetail props to component in layout tree. * Style updates for product detail page configuration. * Remove logger, as it doesn't provide useful data in its current form * Adds ability to add react template layout to database to render full page views * Adds ability to use media queries when defining blocks * add missing dependency for radium * fix broken template tests
* added some comments to break up html table * reorganized data for email template removed all [0]. type variables from new.html email template, so all variables are set in orders.js for easy manipulation * welcome to the shop email template * extract social from template, add on/off switch * invite shop member email * shopName variable updates * update reaction address This was driving me crazy seeing the wrong address in all these emails being tested. * add Collections imports for Accounts, Cart, Shopts * password reset emails * update subject of order confirmation email * lint fix * renamed file for email template * removed test text * path file organization * mail -> SMTP for clarification * Merge branch 'release-0.18.0' into email-template-expansion-v2 # Conflicts: # imports/plugins/included/email-templates/lib/paths.js * i18n for email template admin * publication for Templates * conflict fix * add email subject into saved DB data * add server methods for deleting email templates * Add a duplicate, editable template to the template collection (#1548) Mark one of those templates and an original, which can be used to revert editable templates. * server methods for updating email templates * added check for original template * new translations * Merge branch 'release-0.18.0' into email-template-expansion-v2 * core workflow emails - processing & completed * test - new workflow email exports * Update email schema * shipping email * conflict fixes * removed comments * removed comments * import new email schema * template updates * removed commented code * organize templates * added todo to schema * updated comments * cleanup methods file * updated error messaging * schema update * update comments * i18n updates * removed testing alerts * i18n updates * file organization
- remove Authnet/dashboard - unused legacy settings?
Updated Apps, payment packages
* Remove unused settings icon * Fix "required" name field * Update sidebar Reactively when changes are made * Removed references to "email" Templates are not just for emails, so I removed references to “Email” in all the i18n translations * Removed "email" as Templates are more than email * Remove unused functions * Updated i18n * Renamed variable away from "template"
* Fix bug that causes duplicated variants to be missing images. Added a copyFile helper that will bypass revision control to copy a file. * Add missing export
This fix also ensures all metadata related to a product is updated when the product is selected.
…checks audience perms against user roles and registry item audience if any
… from audience check
* Move Template editing to Sidebar * Removed logs * Linting fixes * i18n updates * renamed filed to remove email designation * package name update * add info box around React message
…-perms 1622 Add audience permissions to registry items
Fix Safari websocket connection browser policy
* add applyProductRevision to Products.findOne * fix price range for revisions * fix isVisible price updates * fix for price object not initially being created * add product.range updating to non-revision enabled app
* Fix typo in CircularProgress indetermate -> indeterminate * Enabled false for Express on initial startup * Updated payments method - Replaces `payments/paymentMethod` with `payments/cart/apply` - add discounts/codes/remove - add discounts/codes/apply * Initial DiscountList DiscountForm components * functional discount code input * basic discount calculations in cart * Updated discount input loader * Only display shipping, discounts, taxes gt 0 * Order discount not to exceed 0 (no neg values) * Update plugin structure * fix typo in taxes input numericInputProps "taxes" * apply discounts in order process - DiscountList and DiscountForm components can be used for Orders or Cart collection - working CODES as discounts through order process - a number of outstanding TODO’s remain for discount conditional logic and limit handling - Order process is easily broken, and will need modification to payment handling to check for authorization below above current authorization if discount is removed. * Fix event handling in FF * disable delete discount in admin ui * Format discount * Implement credit/debit payment method selectors - Replace order.billing[0] with credit selector - update and enforce that paymentMethod.method should be “credit”, “debit”. - refactor Order updates to allow for credit to be in any position * Minor lint updates * Updated billing constants * Updated billing constants * Updated selector constants * Set min-height on cart-items - prevent some of the ugly transitions. Needs loader. * add fallback paymentMethod for email - add processor in case there isn’t a storedCard * Add calculation method to schema/forms * info -> debug - for `not creating default admin user”` - for `Reaction.init() has run` * implement hooks for per processor calculation methods * Info -> debug logging * discount, credit, sale, shipping calculations * Discount code form cleanup - add a few additional checks on fresh carts * import indexOf * Codes disabled by default * autoEnable discount-codes - is actually required right now, as the logic in payment doesn’t extend to enabling the package. * Patch link for non-configured payments * Add default calculation method - ensure that rates/discount exists - cleanup jsdocs * Updated orders discounts/credit/shipping summary
* Fixes to inventory tests * Create new versions of cart fixtures that create less "random" versions so that db impact is minimized. * Eliminate unneeded originals entries * Put expectations in callbacks rather than putting in sleeps * Make this global wait more visible * The quantity on remove quantity should always be 1 now that we are using the custom fixture. * Allow direct importing of inventory function * creating createCart function * test for createCart function * Directly call registerInventory to avoid permissions check that doesn't apply * Add singleVariant version of addProduct * Trying to get these tests to run reliably by trying to normalize the inventory beforehand * createCart function * test for createCart function * Change currency symbol for PHP (wut?) * Db-normalized inventory tests * Just blindly increase this timeout * Add comment explaining why we need this long timeout * Remove Logger * Extend timeout on cart test * Add sleep for createVariant tests * Quiet inventory register logging that I should not have put there anyway * Don't operate on product if it's not found * Update to fixed publication-collector * Increase timeout on discount test * Update publication-collector * Don't call Alert in a server method * Lint cleanup
|
👍 Approved release-0.18.0 to merge into |
|
👍 looks good to merge to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Complete: 11/3
Release: 11/15
This release will include the following tickets:
#1429 Create Transactional Email templates
#1515 Ability to modify email templates from the dashboard
#1512 Discounts
#431 Email confirmation on guest order entry
#1224 Order progress status is not correctly being updated on the Orders admin page
#1448 Invitation email - User Name should be invited user not logged in user
#1456 [PDP] Revision images
#1457 Revision for Tags
#1455 Revisions UX updates
#1399 disabled search is displaying
#1503 [PDP] Public/Private mode workflow
#500 Products without Variants
#517 PDP Package.layout implementation
#1480 Placeholders for variant inputs
#1502 [PDP] Use "Archive" instead of "Delete"
#1408 Group payment methods into single app card
Also Resolves: #423