Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PDP] Placeholders for variant inputs #1480

Closed
2 tasks done
aaronjudd opened this issue Oct 6, 2016 · 1 comment · Fixed by #1693
Closed
2 tasks done

[PDP] Placeholders for variant inputs #1480

aaronjudd opened this issue Oct 6, 2016 · 1 comment · Fixed by #1693
Assignees
@mikemurray @aaronjudd
Milestone
v0.18.0

Comments

@aaronjudd
Copy link
Contributor

aaronjudd commented Oct 6, 2016 •
edited by mikemurray
Loading

  • Variant inputs need placeholders
  • All placeholders should be using i18n in the PDP

Related to #1472 and first reported there.
@aaronjudd aaronjudd added this to the v0.17.0 milestone Oct 6, 2016
@aaronjudd aaronjudd mentioned this issue Oct 6, 2016
Merged
@aaronjudd aaronjudd modified the milestones: v0.17.0, v0.18.0 Oct 19, 2016
@brent-hoover brent-hoover assigned jshimko and mikemurray and unassigned jshimko Oct 21, 2016
@brent-hoover brent-hoover mentioned this issue Oct 21, 2016
Merged
@mikemurray mikemurray mentioned this issue Oct 31, 2016
Merged
@ghost ghost added review and removed ready labels Oct 31, 2016
@mikemurray
Copy link
Member

Resolved in PR #1542

@ghost ghost removed the review label Nov 17, 2016
@aaronjudd aaronjudd mentioned this issue Jan 6, 2017
Merged
@ghost ghost assigned aaronjudd Jan 6, 2017
@ghost ghost added the review label Jan 6, 2017
This was referenced Jul 10, 2020
Open
Open
This was referenced Jul 20, 2020
Open
Open
This was referenced Feb 18, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikemurray mikemurray

@aaronjudd aaronjudd

Labels
None yet
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging a pull request may close this issue.

Release 18 reactioncommerce/reaction
3 participants
@mikemurray @aaronjudd @jshimko