Updated Apps, payment packages #1592

aaronjudd · 2016-11-27T21:41:15Z

single card payment layout
updated / refactored Reaction.Apps
normalization of client Packages moved to publication
PayPal and PayFlow split out
removes default payment method and collapse handling in checkout
commented dashboard default method settings. TBD.
resolves Group payment methods into single app card #1408
adds object-curly-spacing lint rule
adds significant i18n to payments, makes local
adds translations to month helpers

…tings

Updated package registry handling, updates for payments.

…tings

Resolve `websocket because it does not appear in the connect-src directive of the Content Security Policy` error in safari when using —production build.

- removes name from some payment method registry entries - use name if separate settings and permissions are needed - applies permission checks in package publication for filtering enabled views - uses package name as default settings key, used when no name

- Cleanup handling in taxes, discounts, catalog package handling - Fix error where registry update was overwriting existing settings - use mergeDeep for registry updates

- remove excessive panels - add i18n - generic alerts - convert panel-title to alert info - show alert message only pre-setup

momentjs:moment upgraded from 2.16.0 to 2.17.0

- Process multiple matching entries in registry - adds i18n for PayPal client views - splits PayPal into two payment methods for settings/checkout - todo add migration for express_enabled to express.enabled - todo add migration for payflow_enabled to payflow.enabled - add browser policy akamai.mathtag.com - apply standard button style + i18n to all payment settings

- single card payment layout - removes default payment method and collapse handling in checkout - commented in dashboard payment settings. TBD. - resolves #1408

brent-hoover · 2016-11-27T21:56:15Z

imports/plugins/core/discounts/server/methods/methods.js

-      // Meteor.call("discounts/setRate", cartToCalc._id, discountRate);
+    if (cartToCalc.discountMethods) {
+      for (discountMethods of cartToCalc.discountMethods) {
+        // get discount based on id in cartMethods.


So is this just a placeholder for a forthcoming implementation of the discount calculation?

Yeah, just wanted to double-check that this intentionally does nothing here

Correct.. it's no harm, no foul at this point...

brent-hoover · 2016-11-27T21:57:19Z

imports/plugins/core/layout/client/templates/layout/admin/admin.js

-import { Reaction, i18next } from "/client/api";
-import { Packages } from "/lib/collections";
-
+import {Meteor} from "meteor/meteor";


Shouldn't we keep the spaces around imports consistent?

Apparently a beautifier rule that wasn't working before.

aaronjudd · 2016-11-27T21:57:31Z

No, this should go ahead and be merged -> it does have the placeholders for rates, and codes, but it's not really related functionality at this point (although had to be done to add codes in the checkout the way I want)

jshimko · 2016-11-27T22:10:02Z

client/modules/core/helpers/apps.js

+import _ from "lodash";
+import {Reaction} from "/client/api";
+import {Packages} from "/lib/collections";
+import {Template} from "meteor/templating";


Bracket spacing, import order.

do we have a rule to enforce this? "space_in_paren": true in the .jsbeautifyrc will add the spaces on save, but also adds in a bunch of other places. Eslint doesn't see anything wrong here.. which would leave me back to disabling .jsbeautify.. (nobody else using this I guess?).

jshimko · 2016-11-27T22:12:07Z

client/modules/i18n/startup.js

@@ -9,6 +9,7 @@ import { Reaction } from "/client/api";
 import { Shops, Translations } from "/lib/collections";
 import * as Schemas from "/lib/collections/schemas";
 import i18next, { packageNamespaces, getLabelsFor, getMessagesFor, i18nextDep } from "./main";
+import {mergeDeep} from "/lib/api";


Bracket spacing

Looks like we need to add the space-in-brackets rule (and make arrays an exception).

http://eslint.org/docs/rules/space-in-brackets

Probably something like...

"space-in-brackets": [2, "always", { "arraysInArrays": false, "arraysInObjects": false }]

This rule was removed in ESLint v1.0 and replaced by the object-curly-spacing and array-bracket-spacing rules.

Alrighty...

"object-curly-spacing": [2, "always"],

"sort-imports": ["error", { "ignoreCase": false, "ignoreMemberSort": false, "memberSyntaxSortOrder": ["none", "all", "multiple", "single"] }], "object-curly-spacing": ["error", "always", { "objectsInObjects": true }],

However, that's going to change 90 files, as --fix rightfully adds spacing to objects all over the place. I'm actually cool with that, but it's new...

Sorts rule isn't quite advanced enough to enforce our rules (I think this basically is just alphabetical).

brent-hoover · 2016-11-28T00:46:05Z

Checking out with the Example payment method I see this error in the console. Order does complete however.


meteor.js?hash=e3f53db…:930 Exception in template helper: TypeError: moment is not a function
    at Object.<anonymous> (http://localhost:3000/app/app.js?hash=65db4f0c5205ad7c0f0dd9cb714deba07c0401e4:50923:12)
    at http://localhost:3000/packages/blaze.js?hash=10a350f1c0d55cf44d3c99989b04ef2e7e0d23f6:3035:16
    at http://localhost:3000/packages/blaze.js?hash=10a350f1c0d55cf44d3c99989b04ef2e7e0d23f6:1697:16
    at http://localhost:3000/packages/blaze.js?hash=10a350f1c0d55cf44d3c99989b04ef2e7e0d23f6:3087:66
    at Function.Template._withTemplateInstanceFunc (http://localhost:3000/packages/blaze.js?hash=10a350f1c0d55cf44d3c99989b04ef2e7e0d23f6:3728:12)
    at http://localhost:3000/packages/blaze.js?hash=10a350f1c0d55cf44d3c99989b04ef2e7e0d23f6:3086:27
    at Spacebars.call (http://localhost:3000/packages/spacebars.js?hash=ebf9381e7fc625d41acb0df14995b7614360858a:172:18)
    at Spacebars.mustacheImpl (http://localhost:3000/packages/spacebars.js?hash=ebf9381e7fc625d41acb0df14995b7614360858a:106:25)
    at Object.Spacebars.mustache (http://localhost:3000/packages/spacebars.js?hash=ebf9381e7fc625d41acb0df14995b7614360858a:110:39)
    at Blaze.View._render (http://localhost:3000/app/app.js?hash=65db4f0c5205ad7c0f0dd9cb714deba07c0401e4:25685:24)

brent-hoover · 2016-11-28T00:50:37Z

I wonder if we shouldn't throw up a warning in the settings panel if no Payment packages are enabled?

brent-hoover · 2016-11-28T00:51:27Z

Seeing this message (not an error) in the console when PayPal PayFlow is enabled:

modules.js?hash=09d32e0…:47071 Deprecation warning: use moment.updateLocale(localeName, config) to change an existing locale. moment.defineLocale(localeName, config) should only be used for creating a new locale See http://momentjs.com/guides/#/warnings/define-locale/ for more info.

brent-hoover · 2016-11-28T00:54:47Z

It doesn't look like we do a client-side validation on Expiration date? For Paypal Payflow I got this error when I submitted a card with an invalid expiration.

aaronjudd · 2016-11-28T00:54:58Z

I did update the way moment is loading, so the first error could be related (try to get to that one reproduced right now). Re: the deprecation warning.. that's because we need more garbage debugging on that page that we can't shut off. oh no wait, it's because I am using defineLocale to add an alias to ZH, which is what it seems to be indicating is the correct purpose, not the deprecated purpose.... I think..

aaronjudd · 2016-11-28T00:58:48Z

re: client side validation - no, there is not any validation to speak of other than autoform stuff. nothing new here. however, I've been talking about having a credit card / payment method component for a while, to replace this input form with a nice modern input validator, aka card.js etc. I was holding myself back, but if you are suggesting it's a must have..

brent-hoover · 2016-11-27T22:26:43Z

imports/plugins/included/payments-authnet/server/i18n/en.json

@@ -16,7 +16,9 @@
        },
        "paymentSettings": {
          "authorizenetLabel": "Authorize.net",
-          "authorizenetSettingsLabel": "Authorize.net"
+          "authorizenetSettingsLabel": "Authorize.net",
+          "authorizenetCredentials": "Don't have a AuthNet API Login ID and Transaction Key?",


should probably be "an Authnet"?

brent-hoover · 2016-11-28T01:09:52Z

Approved - Except for the couple of minor things I think this is a nice step forward, especially on the consumer-side where I thought that part was probably confusing.

brent-hoover · 2016-11-28T01:13:13Z

It seems like Paypal Express is enabled by default?

brent-hoover · 2016-11-28T01:16:46Z

This checkbox looks a little odd (Paypal Express)

brent-hoover · 2016-11-28T01:23:52Z

If I have no payment methods specified, in FF, instead of seeing the "No Payment" message I see all payment methods

aaronjudd · 2016-11-28T01:26:34Z

the way it's setup now, you'll see all the payment methods if you are logged in as admin in checkout, the view restriction is permission based now (or at least partially) (see the transform in Packages publication). I'd like to see us narrow this down with an implementation of "audience" permissions checks. The consumer/client should only be seeing what's enabled.

aaronjudd · 2016-11-28T01:28:49Z

re: defaults, I set the initial to have "PayPal express" and "Example" enabled.

- could have just used if in template, or alternate display - but this is clean and simple for now.

Fix error loading moment for template helpers.

- remove Authnet/dashboard - unused legacy settings?

aaronjudd · 2016-11-28T15:29:26Z

@zenweasel All issues you reported should now be addressed. Ready to merge.

aaronjudd added 19 commits November 10, 2016 22:15

move discount rates to catalog/codes to payments

bc83c9e

restore default method data

b7db046

Merge branch 'release-0.18.0' into discount-code-payments

02cfdd2

Merge branch 'release-0.18.0' into discount-code-payments

6aa638e

Merge branch 'release-0.18.0' into discount-code-payments

17585fb

Merge branch 'release-0.18.0' into discount-code-payments

94c3c99

[WIP] Updates to package registry

3a780d5

Merge remote-tracking branch 'origin/release-0.18.0' into package-set…

bfbc451

…tings

updated reaction Apps

7ab967c

Updated package registry handling, updates for payments.

Merge remote-tracking branch 'origin/release-0.18.0' into package-set…

ac48108

…tings

Add localhost WS browser-policy

2e25174

Resolve `websocket because it does not appear in the connect-src directive of the Content Security Policy` error in safari when using —production build.

Move mergeDeep into /lib/api/helpers

a4704d6

Update settings handling

b9865ed

- Cleanup handling in taxes, discounts, catalog package handling - Fix error where registry update was overwriting existing settings - use mergeDeep for registry updates

Cleanup panels in payments, taxes

2869e66

- remove excessive panels - add i18n - generic alerts - convert panel-title to alert info - show alert message only pre-setup

Updated package

3d56c34

momentjs:moment upgraded from 2.16.0 to 2.17.0

Add Month Translations to monthOptions helper

1588b3e

updated payments styling, missing i18n

73561ed

- single card payment layout - removes default payment method and collapse handling in checkout - commented in dashboard payment settings. TBD. - resolves #1408

aaronjudd added the review label Nov 27, 2016

aaronjudd assigned brent-hoover Nov 27, 2016

brent-hoover reviewed Nov 27, 2016

View reviewed changes

jshimko reviewed Nov 27, 2016

View reviewed changes

object-curly-spacing lint rules applied

86d2199

aaronjudd assigned jshimko Nov 27, 2016

brent-hoover reviewed Nov 28, 2016

View reviewed changes

aaronjudd added 2 commits November 27, 2016 17:19

Avoid localLocale.defineLocale warning

46ec4e6

Clarify Auth.net credentials messaging

66a8f00

aaronjudd added 4 commits November 27, 2016 19:31

Only display enabled payment methods to admin in checkout

100bafe

- could have just used if in template, or alternate display - but this is clean and simple for now.

Updated import/requires for moment

ea74c21

Fix error loading moment for template helpers.

Updated translation

41aa37b

Update styling for payment settings

35cf759

- remove Authnet/dashboard - unused legacy settings?

aaronjudd merged commit a1bae0b into release-0.18.0 Nov 28, 2016

aaronjudd deleted the package-settings branch November 28, 2016 15:48

aaronjudd removed the review label Nov 28, 2016

spencern mentioned this pull request Oct 11, 2017

Release 1.5.0 #3089

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated Apps, payment packages #1592

Updated Apps, payment packages #1592

aaronjudd commented Nov 27, 2016 •

edited

Loading

brent-hoover Nov 27, 2016

brent-hoover Nov 27, 2016

aaronjudd Nov 27, 2016

brent-hoover Nov 27, 2016

aaronjudd Nov 27, 2016

aaronjudd commented Nov 27, 2016

jshimko Nov 27, 2016

aaronjudd Nov 27, 2016

jshimko Nov 27, 2016

jshimko Nov 27, 2016 •

edited

Loading

aaronjudd Nov 27, 2016

jshimko Nov 27, 2016

aaronjudd Nov 27, 2016

brent-hoover commented Nov 28, 2016

brent-hoover commented Nov 28, 2016

brent-hoover commented Nov 28, 2016

brent-hoover commented Nov 28, 2016

aaronjudd commented Nov 28, 2016

aaronjudd commented Nov 28, 2016

brent-hoover Nov 27, 2016

brent-hoover commented Nov 28, 2016

brent-hoover commented Nov 28, 2016

brent-hoover commented Nov 28, 2016 •

edited by aaronjudd

Loading

brent-hoover commented Nov 28, 2016

aaronjudd commented Nov 28, 2016 •

edited

Loading

aaronjudd commented Nov 28, 2016

aaronjudd commented Nov 28, 2016

Updated Apps, payment packages #1592

Updated Apps, payment packages #1592

Conversation

aaronjudd commented Nov 27, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aaronjudd commented Nov 27, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jshimko Nov 27, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brent-hoover commented Nov 28, 2016

brent-hoover commented Nov 28, 2016

brent-hoover commented Nov 28, 2016

brent-hoover commented Nov 28, 2016

aaronjudd commented Nov 28, 2016

aaronjudd commented Nov 28, 2016

Choose a reason for hiding this comment

brent-hoover commented Nov 28, 2016

brent-hoover commented Nov 28, 2016

brent-hoover commented Nov 28, 2016 • edited by aaronjudd Loading

brent-hoover commented Nov 28, 2016

aaronjudd commented Nov 28, 2016 • edited Loading

aaronjudd commented Nov 28, 2016

aaronjudd commented Nov 28, 2016

aaronjudd commented Nov 27, 2016 •

edited

Loading

jshimko Nov 27, 2016 •

edited

Loading

brent-hoover commented Nov 28, 2016 •

edited by aaronjudd

Loading

aaronjudd commented Nov 28, 2016 •

edited

Loading