refactor(breaking): remove deprecated link, unlink and associated code
#1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for broader coverage
grabbou
changed the title
link, unlink and associated codelink, unlink and associated code
This was referenced May 31, 2022
|
First feedback coming in from react-native-vector-icons user, and it's basically, "Okay so now what do I do?" |
This was referenced Jun 23, 2022
This was referenced Jun 24, 2022
This was referenced Jun 25, 2022
4 tasks
stackchain
added a commit
to Emurgo/csl-mobile-bridge
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR removes the code related to
link,unlinkandrnpmand is a first shot at cleaning up the codebase. It is not going to clean up all the places automatically, but it's a first step.List of changes:
link,unlink,installanduninstallcommands from the CLIrnpm, together with migration guidesIOSProjectConfig,AndroidProjectConfigthat were used forlink, and not utilised in a new autolinking mechanism. That means things such asassetsorhooksare no longer allowed to be present on a configuration and will cause an error when CLI validates the structure of your config.IOSProjectParams,AndroidProjectParams,IOSDependencyParamsandAndroidDependencyParamsthat were used to override settings forlinkthat are no longer needed.podspecPathfor an iOS dependency. This was already marked as deprecated and set to be removed--project-pathoption from arun-iosCLI command. This was meant to set a source directory for iOS files (unless it equals toiOS). It is now using the detection fromconfig, which makes sure thatrun-iosuses the same folder that autolinking and other commands (very important for debugging)xcodeprojorxcworkspacebecause that is whatlinkneeded to work and manipulate. The new autolinking relies on a Podfile only. There are certain use cases where Podfile is the only file present in a project (e.g. Xcode files are generated programatically or abstracted away). We still keep an information aboutxcodeProjectwe detected, as it is used for commands such asupgrade. I believe this may change in the future, so I wouldn't recommend relying too much on it.We will explain the differences in types/configuration later in a form of a changelog/blog post. Right now, if you want to learn more about the changes, simply check the
diffforcli-typespackage or a documentation.Todo in a follow-up PRs:
getProjectConfigon iOS. They are missing and its important to cover themrun-androidcommand. It is the right time to do it nowlink,unlinkand associated code #1537 (review)