Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Autolinking for React Native 0.69 #981

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Conversation

DmitriyKirakosyan
Copy link
Contributor

@DmitriyKirakosyan DmitriyKirakosyan commented Jul 5, 2022

Things to consider before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Moved podspec location to root directory of project as it is required for autolinking to work in react-native/cli v8
Also removed podspecPath from react-native.config as the parameter is deprecated, making autolink to fail

react-native-community/cli#1537

A few sentences describing the overall goals of the pull request.

Related PRs or issues

List related PRs and other issues.
#979

Misc

Add what's missing, notes on what you tested, additional thoughts or questions.

@Zestpond
Copy link

Zestpond commented Jul 6, 2022

Good news

@DmitriyKirakosyan DmitriyKirakosyan merged commit fceb22c into develop Jul 6, 2022
@DmitriyKirakosyan DmitriyKirakosyan deleted the fix/podInstall branch July 6, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants