Remove link/unlink scripts & large dependencies #2176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newyankeecodeshop
changed the title
|
Hi @alexandergoncharov do you have any feedback for this PR? |
|
Hi @newyankeecodeshop, @doomkit , could you please take a look? :) |
|
Happy 2022 @doomkit , can you review this PR for me? |
|
Hi @doomkit , can this PR get a look? Thank you |
|
The React Native CLI has removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scripts for linking & unlinking the library using the old React Native package manager include three dependencies:
inquirerplistsemverInquirer is a large dependency that takes up almost 24MB in a typical install. Since these scripts are no longer used with React Native 0.60+, they and their dependencies are no longer needed in this project. I removed the script files and updated
package.json.I verified the change by running all tests without incident.