fix: add exclude rules #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: kube deployment name-limit handling
chore: change odpf references to goto
* fix: golanci config * fix: gci lint issues * fix: lint issues * fix: remove nosnakecase lint from disable list
* fix: deployment id name
* chore: add better error description * refactor: merge firehose module files
refactor: reduce firehose package
* feat: implement create, update, reset * feat: implement upgrade * feat: implement start, stop, scale * test: add lots of tests * feat: implement reset-sync * refactor: simplify kafka reset flow * feat: implement log * refactor: separate client & server CLI * feat: fix entropy client cli
* fix: use previous telegraf conf * refactor: remove old firehose module
fix: change commit author to bot
* fix: strip trailing colon in image tag * feat: add telegraf config templating
This reverts commit 2b799d7.
* test: payloads sent to LOG, BQ and GCS/BLOB sinks * fix: lint issue
* fix: add delay before executing reset - kafka takes some time before it registers the stopped consumer - hence when we try to attemp the reset immediately, it fails - even though it fails, it does not return a failed response * feat: make delay configurable * chore: update comment * Update driver.go * change time to seconds * feat: handle context cancellation
* fix: use deployment id for deriving job name * refactor: remove var declaration
* fix: remove -firehose from job name * fix: lint issue
* feat: use group incremental reset strategy * test: getNewConsumerGroupID * fix: lint issue * fix: lint issue * fix: use regex * fix: lint issue * test: fix group id numbers * fix: use shorted if syntax * fix: test * fix: readConfig * refactor: rename new-reset to reset-v2 * fix: error message * fix: var name * fix: var name
* fix: empty body while logging - body was read while processing the request - made a copy of the body buffer, to log later * refactor: use io.Copy * fix: use io.Readall * fix: return if body reading fails * fix: change log type to error
* feat: adding job module * test: add test * chore: verion update * chore: lint version upgrade * lint: lint fixes * chore: revert back lint version * fix: fix import naming and config * Update modules/job/config/config.go Co-authored-by: Abduh <[email protected]> * Update modules/job/driver/driver.go Co-authored-by: Abduh <[email protected]> * Update pkg/kube/client.go Co-authored-by: Abduh <[email protected]> * fix: review changes * fix: review comments * fix: review comments * chore: review comments * feat: add suspend and start job * fix: linting issues * fix: linting issues --------- Co-authored-by: Abduh <[email protected]>
* feat: add sequence if group id does not have it" * refactor: use fmt package * fix: lint issue
* feat: output refresh for job module * feat: add logging * fix: empty output without crashing * chore: fix comment * refacror: moved log function to module
feat: add on delete cascade to revision tags
* feat: add joins in query
* fix: change filters to lower case
* fix: byteArrayToMap
- error handling
- change regex to avoid matching the last '}' with the value
* chore: rename helper function and structs
* fix: add case of {NULL} in data
* rebase * test: fix mocks * fix: remove regex
* fix: allow overiding user passed resource & limits * test: add resource limit update test
* feat: add sink based ns selection * feat: add namespace to labels * fix: should check exisitng stopped flag * fix: error handling * fix: make private error
* feat: templatize telegraf config output * fix: templatize all keys in output
* fix: remove validation on resource name * fix: have new regex
* chore: if namespace is empty take from default * fix: do not overwrite the namespace
* chore: if namespace is empty take from default * fix: do not overwrite the namespace * fix: take namespace from resource conf
fix: test lint timeout Co-authored-by: Manish Dangi <[email protected]>
* feat: upgrade lint action * feat: set enable-all false * feat: disable typecheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of this bug golangci/golangci-lint#2912