New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding job module #74

Merged

lavkesh merged 19 commits into main from job-module

Sep 29, 2023

Member

lavkesh commented Sep 22, 2023

No description provided.


          feat: adding job module

fdf7407

lavkesh changed the title ~~feat: adding job module~~ [WIP] feat: adding job module

ishanarya0 requested changes

View reviewed changes

modules/job/driver/driver.go Outdated Show resolved Hide resolved

modules/job/config/config.go Outdated Show resolved Hide resolved


          test: add test

7604cc5

lavkesh force-pushed the job-module branch from 652f249 to 7604cc5 Compare

September 26, 2023 13:13

lavkesh added 2 commits

September 26, 2023 21:23


          chore: verion update


          chore: lint version upgrade

6e6b3bc

mabdh reviewed

View reviewed changes

modules/utils/utils.go Outdated Show resolved Hide resolved

mabdh reviewed

View reviewed changes

modules/firehose/driver.go Outdated Show resolved Hide resolved

mabdh reviewed

View reviewed changes

core/core.go Outdated Show resolved Hide resolved

mabdh reviewed

View reviewed changes

modules/job/config/config.go Show resolved Hide resolved

mabdh reviewed

View reviewed changes

modules/job/config/config.go Outdated Show resolved Hide resolved


          lint: lint fixes

0be062a

mabdh reviewed

View reviewed changes

modules/job/config/config.go Outdated Show resolved Hide resolved

lavkesh force-pushed the job-module branch from ee608a0 to 0be062a Compare

September 26, 2023 14:35

mabdh reviewed

View reviewed changes

modules/job/driver/driver.go Outdated Show resolved Hide resolved

modules/job/driver/models.go Outdated Show resolved Hide resolved

modules/job/driver/models.go Outdated Show resolved Hide resolved

modules/job/driver/models.go Outdated Show resolved Hide resolved

modules/job/driver/sync.go Outdated Show resolved Hide resolved

modules/job/driver/sync.go Outdated Show resolved Hide resolved

pkg/kube/client.go Outdated Show resolved Hide resolved

pkg/kube/job/processor.go Show resolved Hide resolved

lavkesh and others added 11 commits

September 27, 2023 14:15


          Merge branch 'main' into job-module

8786f7e


          chore: revert back lint version

940da26


          Merge branch 'main' into job-module

6cf0a36


          fix: fix import naming and config

9e9cd08


          Update modules/job/config/config.go

Co-authored-by: Abduh <[email protected]>


          Update modules/job/driver/driver.go

44b768c

Co-authored-by: Abduh <[email protected]>


          Update pkg/kube/client.go

647a0b0

Co-authored-by: Abduh <[email protected]>


          fix: review changes

55cba6e


          fix: review comments

da16f29


          fix: review comments

ce6cc15


          chore: review comments

ac2d5cc

Member

mabdh commented Sep 29, 2023

@lavkesh try changing golang-ci lint to version v1.54.2 in the workflow

lavkesh added 2 commits

September 29, 2023 17:08


          feat: add suspend and start job

4c8fdad


          fix: linting issues

39abc26


          fix: linting issues

65ad7c4

lavkesh changed the title ~~[WIP] feat: adding job module~~ feat: adding job module

mabdh self-requested a review

September 29, 2023 10:23

mabdh approved these changes

View reviewed changes

ishanarya0 self-requested a review

September 29, 2023 10:24

ishanarya0 approved these changes

View reviewed changes

lavkesh merged commit f0f1a8c into main

4 checks passed

mabdh linked an issue

that may be closed by this pull request

New kubernetes job module #68

Closed

mabdh mentioned this pull request

New kubernetes job module #68

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet