Skip to content

Commit

Permalink
feat: adding job module (#74)
Browse files Browse the repository at this point in the history
* feat: adding job module

* test: add test

* chore: verion update

* chore: lint version upgrade

* lint: lint fixes

* chore: revert back lint version

* fix: fix import naming and config

* Update modules/job/config/config.go

Co-authored-by: Abduh <[email protected]>

* Update modules/job/driver/driver.go

Co-authored-by: Abduh <[email protected]>

* Update pkg/kube/client.go

Co-authored-by: Abduh <[email protected]>

* fix: review changes

* fix: review comments

* fix: review comments

* chore: review comments

* feat: add suspend and start job

* fix: linting issues

* fix: linting issues

---------

Co-authored-by: Abduh <[email protected]>
  • Loading branch information
lavkesh and mabdh authored Sep 29, 2023
1 parent e6b56cc commit f0f1a8c
Show file tree
Hide file tree
Showing 48 changed files with 1,900 additions and 628 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ jobs:
steps:
- uses: actions/setup-go@v2
with:
go-version: "1.18"
go-version: "1.21"
- uses: actions/checkout@v2
with:
fetch-depth: 0
- name: golangci-lint
uses: golangci/golangci-lint-action@v2
with:
skip-go-installation: true
version: v1.46.2
version: v1.51.2
args: --timeout=10m
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-go@v2
with:
go-version: "1.18"
go-version: "1.21"
- name: Login to DockerHub
uses: docker/login-action@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-go@v2
with:
go-version: "1.18"
go-version: "1.21"
- name: run tests
run: make test
64 changes: 33 additions & 31 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
run:
go: '1.17'
go: '1.21'
timeout: 10m
skip-files:
- expt/main.go
Expand All @@ -8,38 +8,40 @@ output:
format: colored-line-number

linters:
enable-all: true
disable:
- exhaustruct
- cyclop
- exhaustive
- exhaustivestruct
- exhaustruct
- funlen
- gochecknoglobals
disable-all: true
enable:
- bodyclose
- depguard
- dogsled
- dupl
- errcheck
- exportloopref
- gci
- gochecknoinits
- goconst
- gocritic
- gocyclo
- godox
- gofumpt
- golint
- interfacer
- lll
- maintidx
- ireturn
- maligned
- nlreturn
- gofmt
- goimports
- gomnd
- goprintffuncname
- gosec
- gosimple
- govet
- decorder
- ineffassign
- misspell
- nakedret
- noctx
- nolintlint
- prealloc
- promlinter
- scopelint
- tagliatelle
- testpackage
- paralleltest
- tparallel
- containedctx
- varnamelen
- wrapcheck
- wsl

- revive
- staticcheck
- stylecheck
- typecheck
- unconvert
- unparam
- unused
- whitespace
linters-settings:
decorder:
dec-order:
Expand Down
2 changes: 1 addition & 1 deletion cli/client/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func parseFile(filePath string, v protoreflect.ProtoMessage) error {
}

default:
return errors.New("unsupported file type") // nolint
return errors.New("unsupported file type")
}

return nil
Expand Down
2 changes: 2 additions & 0 deletions cli/serve.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"github.com/goto/entropy/internal/store/postgres"
"github.com/goto/entropy/modules"
"github.com/goto/entropy/modules/firehose"
"github.com/goto/entropy/modules/job"
"github.com/goto/entropy/modules/kubernetes"
"github.com/goto/entropy/pkg/logger"
"github.com/goto/entropy/pkg/telemetry"
Expand Down Expand Up @@ -80,6 +81,7 @@ func setupRegistry() module.Registry {
supported := []module.Descriptor{
kubernetes.Module,
firehose.Module,
job.Module,
}

registry := &modules.Registry{}
Expand Down
Loading

0 comments on commit f0f1a8c

Please sign in to comment.