forked from raystack/entropy
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add delay before executing reset #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ishanarya0
commented
Sep 8, 2023
•
edited
Loading
edited
- kafka takes some time before it registers the stopped consumer
- hence when we try to attempt the reset immediately, it fails
- even though it fails, it does not return a failed response
- adding a delay of 10 seconds before performing reset
- kafka takes some time before it registers the stopped consumer - hence when we try to attemp the reset immediately, it fails - even though it fails, it does not return a failed response
AkarshSatija
reviewed
Sep 8, 2023
spy16
reviewed
Sep 8, 2023
spy16
reviewed
Sep 8, 2023
spy16
reviewed
Sep 8, 2023
spy16
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.