-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable multi verifier name #1187
feat: Enable multi verifier name #1187
Conversation
Going to keep the old CLI user behavior: when user only provided name in the config.json, verifier report will not show type field. |
added e2e test |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm overall
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @junczhu for pushing this through! LGTM. I advise to wait for @binbin-li final sign off too.
e2e on AKS: ZAFT-Armored-Keeper-of-Unity#11 |
Description
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1066
Introduced a verifier name and a verifier type (specName) to the existing VerifierConfig and VerifierPlugin. This way we can support multiple of the same verifier type. In the verifier controller, the Name field in the VerifierConfig has been set to the objectName which is the spec.metadata.name field (this is the unique verifier identifier and different from the verifier type). The previous Name field, and currently specName field, in the VerifierConfig is used to determine whether to run a particular verifier or not on an artifact. Almost closer to a verifier type than the individual verifier spec.metadata.name field.
Before:
After:
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change