-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: introduce verifier type #43
Conversation
✅ Deploy Preview for ratify-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
docs/reference/verifier.md
Outdated
|
||
| Property | Type | IsRequired | Description | | ||
| -------- | -------- | -------- | --------- | | ||
| name | string | true |The name of the plugin that should match with plugin binary on disk. Must not contain characters disallowed in file paths for the system (e.g. / or \) | | ||
| name | string | true |The name of the plugin that should match with plugin binary on disk. Must not contain characters disallowed in file paths for the system (e.g. / or \). `name` can be customized when `type` has been specified. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should mention that when type
is not provided, name
would behave like type
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The binary naming is also confusing to me. If only the name is specified then the binary name must match but otherwsie the binary must match the type
field right?
@junczhu do you think we should update all the configs and verifier report samples we have in the docs to add the |
We can discuss that at the next community meeting. As discussed, I would open a new PR for the updates, and comment about the change applies to the release version 1.1.0 and this change is backward compatible. |
introduce verifier type to the
verifier spec
andverification result version