Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VerifierReport should contain both verifierType and verifierName while using Rego Policy #1066

Closed
1 task
binbin-li opened this issue Sep 7, 2023 · 0 comments · Fixed by #1187
Closed
1 task
Assignees
Labels
bug Something isn't working
Milestone

Comments

@binbin-li
Copy link
Collaborator

What happened in your environment?

Currently Verifier interface exposes a Name() API for querying the name of the verifier.
image
However, this only works well for 1 verifier of each type. If we want to support multiple verifiers of the same type, it would be difficult for users to distinguish between verification results from those verifiers.
Take the notation verifier as an example:
image
The metadata.name is the actual name for each verifier, and spec.name is the verifierType. The current implementation of Name() API returns the spec.name which could not help distinguish between verifiers of the same type.

And in the CLI mode, the verifier config even doesn't include the spec.name as it's not in the spec.
image

What did you expect to happen?

In both CLI and k8s add-on mode, Ratify should return a verifierReports that contains both verifierName and verifierType which could be used to be evaluated by Rego policy.

What version of Kubernetes are you running?

No response

What version of Ratify are you running?

No response

Anything else you would like to add?

No response

Are you willing to submit PRs to contribute to this bug fix?

  • Yes, I am willing to implement it.
@binbin-li binbin-li added bug Something isn't working triage Needs investigation labels Sep 7, 2023
@yizha1 yizha1 removed the triage Needs investigation label Sep 12, 2023
@yizha1 yizha1 added this to the Future milestone Sep 12, 2023
@luisdlp luisdlp assigned binbin-li and junczhu and unassigned binbin-li Sep 27, 2023
@luisdlp luisdlp modified the milestones: Future, v1.1.0-beta.0 Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants