-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update verifier reference[WIP] #1150
feat: update verifier reference[WIP] #1150
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1150 +/- ##
==========================================
+ Coverage 52.31% 52.62% +0.30%
==========================================
Files 101 101
Lines 6306 6387 +81
==========================================
+ Hits 3299 3361 +62
- Misses 2688 2705 +17
- Partials 319 321 +2 ☔ View full report in Codecov by Sentry. |
@junczhu Thanks for taking this issue up. It's critical for user flexibility. I'm a little confused on the implementation. Maybe I'm not understanding #1066. My understanding is that we need to introduce a verifier name and a verifier type to the existing ^^ lot of conflicting terms in that explanation :). I'm happy to clarify offline my confusion too. thanks. |
@junczhu I have updated the e2e tests required based on k8s bump and gk bump. Please merge main when you have a chance. Thanks |
Description
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1066
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change