Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update verifier reference[WIP] #1150

Conversation

junczhu
Copy link
Collaborator

@junczhu junczhu commented Oct 26, 2023

Description

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #1066

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@junczhu junczhu changed the title [WIP] chore: update verifier reference feat: update verifier reference [WIP] Oct 26, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bcade42) 52.31% compared to head (0db8663) 52.62%.
Report is 26 commits behind head on main.

Files Patch % Lines
pkg/controllers/verifier_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1150      +/-   ##
==========================================
+ Coverage   52.31%   52.62%   +0.30%     
==========================================
  Files         101      101              
  Lines        6306     6387      +81     
==========================================
+ Hits         3299     3361      +62     
- Misses       2688     2705      +17     
- Partials      319      321       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@junczhu junczhu changed the title feat: update verifier reference [WIP] feat: update verifier reference Nov 9, 2023
@junczhu junczhu marked this pull request as ready for review November 9, 2023 18:25
@akashsinghal
Copy link
Collaborator

akashsinghal commented Nov 13, 2023

@junczhu Thanks for taking this issue up. It's critical for user flexibility.

I'm a little confused on the implementation. Maybe I'm not understanding #1066. My understanding is that we need to introduce a verifier name and a verifier type to the existing VerifierConfig? This way we can support multiple of the same verifier type. I see that in the verifier controller, the Name field in the VerifierConfig has been set to the objectName which I assume is the spec.metadata.name field (this is the unique verifier identifier and different from the verifier type). The Name field in the VerifierConfig is used to determine whether to run a particular verifier or not on an artifact. Almost closer to a verifier type than the individual verifier spec.metadata.name field. Is there a plan to add some sort of verifiertype field and update the verifier invocation logic to use that?

^^ lot of conflicting terms in that explanation :). I'm happy to clarify offline my confusion too. thanks.

@junczhu junczhu changed the title feat: update verifier reference feat: update verifier reference[WIP] Nov 16, 2023
@junczhu junczhu marked this pull request as draft November 16, 2023 08:52
@akashsinghal
Copy link
Collaborator

@junczhu I have updated the e2e tests required based on k8s bump and gk bump. Please merge main when you have a chance. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VerifierReport should contain both verifierType and verifierName while using Rego Policy
2 participants