-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add breaking change Slack notifier #257
Add breaking change Slack notifier #257
Conversation
b2200b0
to
fbffe30
Compare
After this PR is approved/merged, I will open follow up PRs in all the relavant RAPIDS repositories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing the logic for calculating what constitutes a "breaking change" is not present in this workflow, but is left for the individual repos to decide? And this workflow just sends the Slack notification?
I see now that this workflow will be applied to PRs with the breaking
label. I don't see a reference to a label event here, so I assume the logic of invoking the workflow on PRs with the label is left to the repos.
Thanks for the review @KyleFromNVIDIA. Note this in the description of this PR:
Once this PR is approved and merged, I will open PRs across all RAPIDS repositories with that labelled event included, just as described in the PR description. |
@KyleFromNVIDIA any further thoughts? |
Adds a workflow that triggers a second workflow which sends a notification to a designated Slack channel on every PR labelled with breaking, whenever any of the following events are triggered on the PR: - closed - reopened - labeled - unlabeled Depends on rapidsai/shared-workflows#257 Authors: - Jake Awe (https://github.com/AyodeAwe) Approvers: - James Lamb (https://github.com/jameslamb) URL: #113
Sends a notification to a designated Slack channel on every PR labelled with
breaking
, whenever any of the following events are triggered on the PR:closed
reopened
labeled
unlabeled
This shared-workflow would be consumed in the following manner:
Example run: