Escape multiline string #259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love your review on this one since you reviewed #257 |
|
Closing this PR and opening one from my fork instead: |
KyleFromNVIDIA
requested changes
Nov 6, 2024
Comment on lines
+69
to
+73
| local flag="-R" | ||
| if [ "$2" = "stream" ]; then | ||
| flag="-sR" | ||
| fi | ||
| echo "$1" | jq ${flag} -c . | grep -E '^".*"$' | awk '{print substr($0, 2, length($0) - 2)}' && [ "${PIPESTATUS[2]}" -eq 0 ] |
There was a problem hiding this comment.
I see no reason to differentiate between a single-line string and a multi-line string. The behavior is the same either way for a single-line string, and is an improvement for a multi-line string. Why not just treat it as multi-line unconditionally?
Suggested change
| local flag="-R" | |
| if [ "$2" = "stream" ]; then | |
| flag="-sR" | |
| fi | |
| echo "$1" | jq ${flag} -c . | grep -E '^".*"$' | awk '{print substr($0, 2, length($0) - 2)}' && [ "${PIPESTATUS[2]}" -eq 0 ] | |
| echo "$1" | jq -sR -c . | grep -E '^".*"$' | awk '{print substr($0, 2, length($0) - 2)}' && [ "${PIPESTATUS[2]}" -eq 0 ] |
There was a problem hiding this comment.
@KyleFromNVIDIA left a comment here.
| @@ -75,7 +79,7 @@ jobs: | |||
| echo "repo=$(escape_json "${REPO}")" >> $GITHUB_OUTPUT | |||
| echo "pr_number=${PR_NUMBER}" >> $GITHUB_OUTPUT | |||
| echo "pr_title=$(escape_json "${PR_TITLE}")" >> $GITHUB_OUTPUT | |||
| echo "pr_body=$(escape_json "${PR_BODY}")" >> $GITHUB_OUTPUT | |||
| echo "pr_body=$(escape_json "${PR_BODY}" stream)" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
Suggested change
| echo "pr_body=$(escape_json "${PR_BODY}" stream)" >> $GITHUB_OUTPUT | |
| echo "pr_body=$(escape_json "${PR_BODY}")" >> $GITHUB_OUTPUT |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a small issue with multiline strings passed to
pr_bodyhere.Follow up PR to #257