Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breaking change workflow trigger #1719

Open
wants to merge 3 commits into
base: branch-25.02
Choose a base branch
from

Conversation

AyodeAwe
Copy link
Contributor

@AyodeAwe AyodeAwe commented Nov 5, 2024

Adds a workflow that triggers a second workflow which sends a notification to a designated Slack channel on every PR labelled with breaking, whenever any of the following events are triggered on the PR:

  • closed
  • reopened
  • labeled
  • unlabeled

Depends on rapidsai/shared-workflows#257

@AyodeAwe AyodeAwe requested a review from a team as a code owner November 5, 2024 18:37
@AyodeAwe AyodeAwe added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function 0 - Blocked Cannot progress due to external reasons labels Nov 5, 2024
@AyodeAwe AyodeAwe marked this pull request as draft November 5, 2024 20:48
@AyodeAwe AyodeAwe added breaking Breaking change and removed 0 - Blocked Cannot progress due to external reasons labels Nov 6, 2024
@AyodeAwe AyodeAwe removed the non-breaking Non-breaking change label Nov 6, 2024
@AyodeAwe AyodeAwe marked this pull request as ready for review November 6, 2024 20:02
@AyodeAwe AyodeAwe added the 0 - Backlog In queue waiting for assignment label Nov 6, 2024
@AyodeAwe AyodeAwe marked this pull request as draft November 6, 2024 20:57
@AyodeAwe AyodeAwe removed the 0 - Backlog In queue waiting for assignment label Nov 7, 2024
@AyodeAwe AyodeAwe marked this pull request as ready for review November 14, 2024 15:29
@harrism
Copy link
Member

harrism commented Nov 19, 2024

Is this going into 24.12 or 25.02?

@AyodeAwe
Copy link
Contributor Author

AyodeAwe commented Nov 19, 2024

Is this going into 24.12 or 25.02?

24.12. It's a trivial addition

@harrism
Copy link
Member

harrism commented Nov 19, 2024

Trivial or not, we are entering code freeze soon.

@AyodeAwe AyodeAwe changed the base branch from branch-24.12 to branch-25.02 November 20, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

2 participants