Add wheel builds to rmm #1148
Add wheel builds to rmm #1148
Conversation
This reverts commit 0e08199.
| from setuptools import find_packages | ||
| from skbuild import setup | ||
|
|
||
| import versioneer | ||
|
|
||
| setup( | ||
| name="rmm", | ||
| version=versioneer.get_version(), | ||
| name="rmm" + os.getenv("RAPIDS_PY_WHEEL_CUDA_SUFFIX", default=""), |
There was a problem hiding this comment.
Am wondering if there is a way to keep the name unchanged. Could we have a common dependency? Are there other ways to encode this information?
There was a problem hiding this comment.
Could you elaborate on the solution that you are proposing with a common dependency? The purpose of this approach is to support installation into environments with different API incompatible versions of CUDA. Specifically, once we start supporting CUDA 12 we will need wheels built specifically for the appropriate CUDA major version. Without first class support in the wheel spec itself I am not sure how else we can handle this other than to have separate packages.
There was a problem hiding this comment.
@jakirkham in order to expedite getting wheels done for this release I'm going to go ahead and merge this PR, but I'm happy to revise anything in follow-ups if we can come up with a better solution so please respond and continue the conversation. If we come up with something soon I would even be open to addressing it this release, although that might be tricky given how much of our wheels-related infrastructure is currently built around the -cu11 suffix (we've been cleaning lots of things up, and the suffix is configurable during builds, but I am sure we also have it hardcoded in many places like dependency installations that would also need updating).
|
@gpucibot merge |
Description
This PR enables building wheels in RMM.
Checklist