Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wheel builds to rmm #1148
Add wheel builds to rmm #1148
Changes from all commits
464aa91
bc2d362
f49eb33
2c72c0c
cd31d84
576505a
6d92685
e9e4247
bab2f77
3fdc703
898f854
3122914
8cb51a5
327680e
273e7fe
41a3164
297383b
22f2828
55c327e
523222a
545309b
89e35a3
67579b2
b48d121
3857250
e45f84b
76a5fbf
6c6df2a
905dbc4
add8649
5d628a2
4786160
9564b2b
fbed104
54fc2d2
ba45124
6ed0534
af55d45
fa6bdfe
5d2c141
0399b13
5c01d45
8fd902c
4be4834
b82c4f6
fbad4eb
659d033
8c22f44
4f70bf0
7d9ae17
e361d5d
7c5ff2d
7465a5f
70db765
8bb6912
f2b11af
087694b
b3b93cc
b9c8abd
1c47dd8
c4c6f18
b80f657
4f4bd9c
f070f10
4f0fafa
b8667ea
41bc691
45bf708
d4bc26b
e910514
ebb9153
681a7d0
51e1a39
99d83e5
37bce63
9ef5d35
a514586
e0b4842
2ddba76
b5b34c1
faebfb6
045ca6b
d9c9dae
cd5e76f
a10a8e5
26641c0
a0b2ffa
2eaa56a
6de41e3
0a7b19c
162380e
b9ca278
1c5dfb7
fd0b93c
693cf1f
04d343b
13a9d9e
0e08199
7d6310d
3c963a5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am wondering if there is a way to keep the
name
unchanged. Could we have a common dependency? Are there other ways to encode this information?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate on the solution that you are proposing with a common dependency? The purpose of this approach is to support installation into environments with different API incompatible versions of CUDA. Specifically, once we start supporting CUDA 12 we will need wheels built specifically for the appropriate CUDA major version. Without first class support in the wheel spec itself I am not sure how else we can handle this other than to have separate packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakirkham in order to expedite getting wheels done for this release I'm going to go ahead and merge this PR, but I'm happy to revise anything in follow-ups if we can come up with a better solution so please respond and continue the conversation. If we come up with something soon I would even be open to addressing it this release, although that might be tricky given how much of our wheels-related infrastructure is currently built around the
-cu11
suffix (we've been cleaning lots of things up, and the suffix is configurable during builds, but I am sure we also have it hardcoded in many places like dependency installations that would also need updating).