Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wheel builds #12096

Merged
merged 146 commits into from
Nov 18, 2022
Merged

Add wheel builds #12096

merged 146 commits into from
Nov 18, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 8, 2022

Description

This PR enables building wheels. It mostly leverages various build options that have already been added to the repository.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

sevagh and others added 30 commits September 27, 2022 14:08
@sevagh
Add initial cibuildwheel workflow
bffc81d
@sevagh
Install cupy for cudf smoke test
65e2fe4
@sevagh
Switch to pyarrow==9.0.0
80b5f94
@sevagh
Add pyarrow smoke test
b9278ab
@sevagh
Unit tests during cibuildwheel
2f4a1f5
@sevagh
DRY wheel workflow with unit tests
abb25ec
@sevagh
Add wheel pattern override
41ff0af
@sevagh
Run CPP unit tests with _venv_placeholder
4a58cc8
@sevagh
Install libprotobuf-dev before unit test
75657d4
@sevagh
Debug stub issue
744c92b
@sevagh
Install tokenizers==0.10.2 to avoid Rust PEP517 compile
da7403c
@sevagh
Retrigger build
4323999
@sevagh
Build dask_cudf
738768d
@sevagh
Rebuild all
2f5b83e
@sevagh
Switch from -cuda11 to -cu11 suffix
72d793b
@sevagh
Run all gtests for libcudf
db601d3
@sevagh
Change libcudf package-name
ea2a171
@sevagh
Don't auditwheel-repair cudf, see what happens
c66c85d
@sevagh
Don't waste time rebuilding libcudf
6a65eb5
@sevagh
Uncomment libcudf
bf9a754
@sevagh
Don't need to unpack python static libs if avoiding building pyarrow …
60e4517 
…from source
@trxcllnt @sevagh
WIP
00a1751
@trxcllnt @sevagh
remove print debugging
04a0ac6
@trxcllnt @sevagh
use the old ABI because arrow
d8f7b3c
@trxcllnt @sevagh
update github action to only build cudf wheel
c95738c
@trxcllnt @sevagh
set include_package_data=True for scikit-build
fae72de
@trxcllnt @sevagh
remove cibw-environment from workflow that doesn't define it
aa42c14
@trxcllnt @sevagh
add cudf to dask_cudf's install_requires
4305233
@trxcllnt @sevagh
switch action repo back to rapidsai
d463e1a
@trxcllnt @sevagh
pass env on a single line
544b341
bdice
bdice approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments. Python looks good. I approve what I could follow from the CMake.

.github/workflows/wheels.yml Show resolved Hide resolved
python/cudf/CMakeLists.txt Outdated Show resolved Hide resolved
@jakirkham jakirkham self-requested a review November 16, 2022 17:27
galipremsagar
galipremsagar approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, made a non-blocking comment here: https://github.com/rapidsai/cudf/pull/12096/files#r1024318438, Shouldn't stop merging for this.

@vyasr vyasr mentioned this pull request Nov 16, 2022
Closed
@vyasr vyasr added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 16, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Nov 17, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6d2a4f0 into rapidsai:branch-22.12 Nov 18, 2022
@vyasr vyasr deleted the feat/cibuildwheel branch November 18, 2022 02:43
@vyasr vyasr mentioned this pull request Nov 29, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller left review comments

@galipremsagar galipremsagar galipremsagar approved these changes

@sevagh sevagh sevagh approved these changes

@bdice bdice bdice approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@jakirkham jakirkham Awaiting requested review from jakirkham

@robertmaynard robertmaynard Awaiting requested review from robertmaynard

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vyasr @robertmaynard @bdice @sevagh @galipremsagar @brandon-b-miller @trxcllnt