Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Roadmap for paying down tech debt in Treelite #2160

Closed
7 tasks done
hcho3 opened this issue Apr 29, 2020 · 4 comments · Fixed by #3316
Closed
7 tasks done

[FEA] Roadmap for paying down tech debt in Treelite #2160

hcho3 opened this issue Apr 29, 2020 · 4 comments · Fixed by #3316
Assignees
Labels
BigConflictCauser Large refactors or similar that will touch many files Build or Dep Issues related to building the code or dependencies conda conda issue feature request New feature or request Perf Related to runtime performance of the underlying code Tech Debt Issues related to debt

Comments

@hcho3
Copy link
Contributor

hcho3 commented Apr 29, 2020

cuML uses dmlc/treelite to implement FIL and tree serialization. Treelite currently has many outstanding issues:

To resolve these issues, I will want to do a whole-sale refactoring of Treelite. The refactoring will be mostly on the build systems and the serialization.

I'm opening this issue to keep track of progress.

@hcho3 hcho3 added ? - Needs Triage Need team to review and classify feature request New feature or request labels Apr 29, 2020
@hcho3 hcho3 changed the title [FEA] Roadmap for upcoming refactoring of Treelite [FEA] Roadmap for paying down tech debt in Treelite Apr 29, 2020
@viclafargue viclafargue added BigConflictCauser Large refactors or similar that will touch many files Build or Dep Issues related to building the code or dependencies conda conda issue Perf Related to runtime performance of the underlying code Tech Debt Issues related to debt and removed ? - Needs Triage Need team to review and classify labels Apr 29, 2020
@hcho3
Copy link
Contributor Author

hcho3 commented Jun 9, 2020

dmlc/treelite#167 has revamped CMake build system for Treelite.

@hcho3
Copy link
Contributor Author

hcho3 commented Jun 17, 2020

Treelite is now officially on Conda: https://anaconda.org/conda-forge/treelite. Install it by running

conda install -c conda-forge treelite=0.92

@hcho3
Copy link
Contributor Author

hcho3 commented Sep 5, 2020

Float64 support is added in dmlc/treelite#196. I plan to break up this pull request into smaller ones for easy reviews.

@hcho3 hcho3 mentioned this issue Dec 17, 2020
8 tasks
@rapids-bot rapids-bot bot closed this as completed in #3316 Jan 7, 2021
rapids-bot bot pushed a commit that referenced this issue Jan 7, 2021
Depends on dmlc/treelite#235, dmlc/treelite#236, dmlc/treelite#237, dmlc/treelite#240, dmlc/treelite#241, dmlc/treelite#242, dmlc/treelite#243

Depends on rapidsai/integration#201

Closes #2160
Closes #2795
Closes #2817

TODOs
- [x] Get code review for dmlc/treelite#235 and dmlc/treelite#236 and merge them
- [x]  Get code review for dmlc/treelite#237 and merge them
- [x] Merge dmlc/treelite#240, dmlc/treelite#241, dmlc/treelite#242, dmlc/treelite#243
- [x] Run tests locally
- [x] Tag a new version of Treelite
- [x] Release a new Conda package with the new version tag
- [x] Update `meta.yml` and the integration package to use the new Treelite
- [x] Run tests (this time build with new Conda package)

Authors:
  - Hyunsu Cho <[email protected]>

Approvers:
  - AJ Schmidt (@ajschmidt8)
  - William Hicks (@wphicks)
  - John Zedlewski (@JohnZed)

URL: #3316
@oreo-lp
Copy link

oreo-lp commented Jul 25, 2023

how about float16?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BigConflictCauser Large refactors or similar that will touch many files Build or Dep Issues related to building the code or dependencies conda conda issue feature request New feature or request Perf Related to runtime performance of the underlying code Tech Debt Issues related to debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants